Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2206533003: Refactor lifetime management of UserMediaController (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 4 months ago
Reviewers:
sof, dcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, tommyw+watchlist_chromium.org, blink-reviews, kinuko+watch, mcasas+watch+mediastream_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor lifetime management of UserMediaController UserMediaController should follow the lifetime model used by other Supplement objects of LocalFrame. This CL doesn't change any behavior. BUG=610176 Committed: https://crrev.com/a3da936580232eadc21374e6c0281ebb23117827 Cr-Commit-Position: refs/heads/master@{#412482}

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Total comments: 2

Patch Set 4 : temp #

Patch Set 5 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M third_party/WebKit/Source/modules/mediastream/UserMediaClient.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaController.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
haraken
PTAL (dcheng@ seems to be OOO for a while, so would you take a look ...
4 years, 4 months ago (2016-08-03 06:12:55 UTC) #4
haraken
dcheng: PTAL
4 years, 4 months ago (2016-08-17 02:20:57 UTC) #6
dcheng
https://codereview.chromium.org/2206533003/diff/40001/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp File third_party/WebKit/Source/web/WebLocalFrameImpl.cpp (right): https://codereview.chromium.org/2206533003/diff/40001/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp#newcode1470 third_party/WebKit/Source/web/WebLocalFrameImpl.cpp:1470: provideUserMediaTo(*m_frame, UserMediaClientImpl::create(m_client->userMediaClient())); Can m_client be null here? It's hard ...
4 years, 4 months ago (2016-08-17 02:32:47 UTC) #7
haraken
https://codereview.chromium.org/2206533003/diff/40001/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp File third_party/WebKit/Source/web/WebLocalFrameImpl.cpp (right): https://codereview.chromium.org/2206533003/diff/40001/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp#newcode1470 third_party/WebKit/Source/web/WebLocalFrameImpl.cpp:1470: provideUserMediaTo(*m_frame, UserMediaClientImpl::create(m_client->userMediaClient())); On 2016/08/17 02:32:47, dcheng wrote: > Can ...
4 years, 4 months ago (2016-08-17 02:41:27 UTC) #8
dcheng
On 2016/08/17 02:41:27, haraken wrote: > https://codereview.chromium.org/2206533003/diff/40001/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp > File third_party/WebKit/Source/web/WebLocalFrameImpl.cpp (right): > > https://codereview.chromium.org/2206533003/diff/40001/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp#newcode1470 > ...
4 years, 4 months ago (2016-08-17 03:15:03 UTC) #9
haraken
On 2016/08/17 03:15:03, dcheng wrote: > On 2016/08/17 02:41:27, haraken wrote: > > > https://codereview.chromium.org/2206533003/diff/40001/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ...
4 years, 4 months ago (2016-08-17 03:45:22 UTC) #10
dcheng
lgtm
4 years, 4 months ago (2016-08-17 03:56:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206533003/80001
4 years, 4 months ago (2016-08-17 04:19:21 UTC) #13
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-17 07:50:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206533003/80001
4 years, 4 months ago (2016-08-17 07:54:03 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-17 09:27:22 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 09:28:56 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a3da936580232eadc21374e6c0281ebb23117827
Cr-Commit-Position: refs/heads/master@{#412482}

Powered by Google App Engine
This is Rietveld 408576698