third_party/WebKit/Source/web/UserMediaClientImpl.h - Issue 2206533003: Refactor lifetime management of UserMediaController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/UserMediaClientImpl.h

Issue 2206533003: Refactor lifetime management of UserMediaController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp ('k') | third_party/WebKit/Source/web/UserMediaClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/UserMediaClientImpl.h

diff --git a/third_party/WebKit/Source/web/UserMediaClientImpl.h b/third_party/WebKit/Source/web/UserMediaClientImpl.h

index 297f9fd64ea80ac12c5c30de504277339059a83f..375cc3e2bf9bb1d45a7d1619d5a6890f6cb025e3 100644

--- a/third_party/WebKit/Source/web/UserMediaClientImpl.h

+++ b/third_party/WebKit/Source/web/UserMediaClientImpl.h

@@ -44,7 +44,10 @@ class WebLocalFrameImpl;

class UserMediaClientImpl final : public UserMediaClient {

public:

- explicit UserMediaClientImpl(WebLocalFrameImpl*);

+ static std::unique_ptr<UserMediaClientImpl> create(WebUserMediaClient* client)

+ {

+ return wrapUnique(new UserMediaClientImpl(client));

+ }

// UserMediaClient ----------------------------------------------

void requestUserMedia(UserMediaRequest*) override;

@@ -54,7 +57,7 @@ public:

void requestSources(MediaStreamTrackSourcesRequest*) override;

void setMediaDeviceChangeObserver(MediaDevices*) override;

private:

- UserMediaClientImpl();

+ explicit UserMediaClientImpl(WebUserMediaClient*);

WebUserMediaClient* m_client;

};