Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/UserMediaController.h

Issue 2206533003: Refactor lifetime management of UserMediaController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 16 matching lines...) Expand all
27 27
28 #include "core/frame/LocalFrame.h" 28 #include "core/frame/LocalFrame.h"
29 #include "modules/mediastream/UserMediaClient.h" 29 #include "modules/mediastream/UserMediaClient.h"
30 30
31 namespace blink { 31 namespace blink {
32 32
33 class MediaDevices; 33 class MediaDevices;
34 class MediaDevicesRequest; 34 class MediaDevicesRequest;
35 class UserMediaRequest; 35 class UserMediaRequest;
36 36
37 class UserMediaController final : public GarbageCollected<UserMediaController>, public Supplement<LocalFrame> { 37 class UserMediaController final : public GarbageCollectedFinalized<UserMediaCont roller>, public Supplement<LocalFrame> {
38 USING_GARBAGE_COLLECTED_MIXIN(UserMediaController); 38 USING_GARBAGE_COLLECTED_MIXIN(UserMediaController);
39 public: 39 public:
40 static UserMediaController* create(UserMediaClient*); 40 static UserMediaController* create(std::unique_ptr<UserMediaClient>);
41 41
42 DECLARE_VIRTUAL_TRACE(); 42 DECLARE_VIRTUAL_TRACE();
43 43
44 UserMediaClient* client() const { return m_client; } 44 UserMediaClient* client() const { return m_client.get(); }
45 45
46 void requestUserMedia(UserMediaRequest*); 46 void requestUserMedia(UserMediaRequest*);
47 void cancelUserMediaRequest(UserMediaRequest*); 47 void cancelUserMediaRequest(UserMediaRequest*);
48 48
49 void requestMediaDevices(MediaDevicesRequest*); 49 void requestMediaDevices(MediaDevicesRequest*);
50 void cancelMediaDevicesRequest(MediaDevicesRequest*); 50 void cancelMediaDevicesRequest(MediaDevicesRequest*);
51 51
52 void requestSources(MediaStreamTrackSourcesRequest*); 52 void requestSources(MediaStreamTrackSourcesRequest*);
53 53
54 void setMediaDeviceChangeObserver(MediaDevices*); 54 void setMediaDeviceChangeObserver(MediaDevices*);
55 55
56 static const char* supplementName(); 56 static const char* supplementName();
57 static UserMediaController* from(LocalFrame* frame) { return static_cast<Use rMediaController*>(Supplement<LocalFrame>::from(frame, supplementName())); } 57 static UserMediaController* from(LocalFrame* frame) { return static_cast<Use rMediaController*>(Supplement<LocalFrame>::from(frame, supplementName())); }
58 58
59 private: 59 private:
60 explicit UserMediaController(UserMediaClient*); 60 explicit UserMediaController(std::unique_ptr<UserMediaClient>);
61 61
62 UserMediaClient* m_client; 62 std::unique_ptr<UserMediaClient> m_client;
63 }; 63 };
64 64
65 inline void UserMediaController::requestUserMedia(UserMediaRequest* request) 65 inline void UserMediaController::requestUserMedia(UserMediaRequest* request)
66 { 66 {
67 m_client->requestUserMedia(request); 67 m_client->requestUserMedia(request);
68 } 68 }
69 69
70 inline void UserMediaController::cancelUserMediaRequest(UserMediaRequest* reques t) 70 inline void UserMediaController::cancelUserMediaRequest(UserMediaRequest* reques t)
71 { 71 {
72 m_client->cancelUserMediaRequest(request); 72 m_client->cancelUserMediaRequest(request);
(...skipping 15 matching lines...) Expand all
88 } 88 }
89 89
90 inline void UserMediaController::setMediaDeviceChangeObserver(MediaDevices* obse rver) 90 inline void UserMediaController::setMediaDeviceChangeObserver(MediaDevices* obse rver)
91 { 91 {
92 m_client->setMediaDeviceChangeObserver(observer); 92 m_client->setMediaDeviceChangeObserver(observer);
93 } 93 }
94 94
95 } // namespace blink 95 } // namespace blink
96 96
97 #endif // UserMediaController_h 97 #endif // UserMediaController_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698