Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp

Issue 2206533003: Refactor lifetime management of UserMediaController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp b/third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp
index b996523dd426e4cc12aa8b88dc2ad971dfc02502..89dcb1fd7ae6f340ea7e24fa72d19ee6a1a5218c 100644
--- a/third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp
@@ -31,8 +31,8 @@ const char* UserMediaController::supplementName()
return "UserMediaController";
}
-UserMediaController::UserMediaController(UserMediaClient* client)
- : m_client(client)
+UserMediaController::UserMediaController(std::unique_ptr<UserMediaClient> client)
+ : m_client(std::move(client))
{
}
@@ -41,14 +41,14 @@ DEFINE_TRACE(UserMediaController)
Supplement<LocalFrame>::trace(visitor);
}
-UserMediaController* UserMediaController::create(UserMediaClient* client)
+UserMediaController* UserMediaController::create(std::unique_ptr<UserMediaClient> client)
{
- return new UserMediaController(client);
+ return new UserMediaController(std::move(client));
}
-void provideUserMediaTo(LocalFrame& frame, UserMediaClient* client)
+void provideUserMediaTo(LocalFrame& frame, std::unique_ptr<UserMediaClient> client)
{
- UserMediaController::provideTo(frame, UserMediaController::supplementName(), UserMediaController::create(client));
+ UserMediaController::provideTo(frame, UserMediaController::supplementName(), UserMediaController::create(std::move(client)));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698