Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2206113002: [WebView] Update CTS logic to load test name from json. (Closed)

Created:
4 years, 4 months ago by mikecase (-- gone --)
Modified:
4 years, 4 months ago
Reviewers:
the real yoland
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[WebView] Update CTS logic to load test name from json. We will want to be able to specify multiple CTS test zips for different android platforms. Adding logic to grab the CTS test name from a formatted json file isntead of just a text file. BUG=633739 Committed: https://chromium.googlesource.com/chromium/tools/build/+/9698e1fca3cdca11d25bdef82986b13ab37c24ca

Patch Set 1 #

Patch Set 2 : [WebView] Update CTS logic to load test name from json. #

Patch Set 3 : [WebView] Update CTS logic to load test name from json. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -95 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 2 4 chunks +27 lines, -18 lines 2 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 1 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_basic.json View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_expected_failure.json View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
A + scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_platform.json View 1 1 chunk +49 lines, -7 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexecuted_tests.json View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_class_failure.json View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_method_failure.json View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_WebView_CTS_L_MR1__dbg_.json View 1 2 5 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mikecase (-- gone --)
Would commit this CL alongside https://codereview.chromium.org/2202853003 Tell me what you think. Your review is powerful ...
4 years, 4 months ago (2016-08-03 01:43:45 UTC) #2
the real yoland
https://codereview.chromium.org/2206113002/diff/40001/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2206113002/diff/40001/scripts/slave/recipe_modules/chromium_android/api.py#newcode1153 scripts/slave/recipe_modules/chromium_android/api.py:1153: android_platform='L', arch='arm_64'): wouldn't the n bot still run this ...
4 years, 4 months ago (2016-08-03 23:25:02 UTC) #3
mikecase (-- gone --)
https://codereview.chromium.org/2206113002/diff/40001/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2206113002/diff/40001/scripts/slave/recipe_modules/chromium_android/api.py#newcode1153 scripts/slave/recipe_modules/chromium_android/api.py:1153: android_platform='L', arch='arm_64'): On 2016/08/03 at 23:25:01, the real yoland ...
4 years, 4 months ago (2016-08-03 23:34:27 UTC) #4
the real yoland
On 2016/08/03 at 23:34:27, mikecase wrote: > https://codereview.chromium.org/2206113002/diff/40001/scripts/slave/recipe_modules/chromium_android/api.py > File scripts/slave/recipe_modules/chromium_android/api.py (right): > > https://codereview.chromium.org/2206113002/diff/40001/scripts/slave/recipe_modules/chromium_android/api.py#newcode1153 ...
4 years, 4 months ago (2016-08-03 23:44:39 UTC) #5
the real yoland
lgtm
4 years, 4 months ago (2016-08-03 23:44:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206113002/40001
4 years, 4 months ago (2016-08-05 18:25:03 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:34:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/9698e1fca3cdca11d25b...

Powered by Google App Engine
This is Rietveld 408576698