[WebView] Update CTS logic to load test name from json.

scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 import datetime
 import json
 import os
 import re
 import sys
@@ skipping 1131 matching lines @@
         '--adb-path', self.m.adb.adb_path(),
         '--device-path', _WEBVIEW_COMMAND_LINE,
         '--executable', 'webview',
     ]
     command_line_script_args.extend(command_line_args)
     self.m.python('write webview command line file',
                   self.m.path['checkout'].join(
                       'build', 'android', 'adb_command_line.py'),
                   command_line_script_args)
 
-  def run_webview_cts(self, command_line_args=None, suffix=None):
+  def run_webview_cts(self, command_line_args=None, suffix=None,
+                      android_platform='L', arch='arm_64'):

[the real yoland, 2016/08/03 23:25:01]

wouldn't the n bot still run this without android_platform specified?

[mikecase (-- gone --), 2016/08/03 23:34:27]

Yes, yeah...............................
So about that...............

2 things.
- Will need to download an N CTS zip and upload it to the bucket.
- It will still not work since the N CTS tests need java8.

Ill update the N CTS tests in a follow up CL if that sounds good.

Also, idk if you have any preference on platform names. I dont see platform
names written out anywhere else in the code. Ill probably have to add whether or
not it is AOSP to the name as well.

'L'
'L_AOSP'

or
'Lollipop'
'Lollipop_AOSP'

or something else?

     suffix = ' (%s)' % suffix if suffix else ''
     if command_line_args:
       self._set_webview_command_line(command_line_args)
 
     _CTS_CONFIG_SRC_PATH = self.m.path['checkout'].join(
         'android_webview', 'tools', 'cts_config')
-    _cts_file_name = self.m.file.read(
-        'Fetch for the name of the cts file',
-        _CTS_CONFIG_SRC_PATH.join('webview_cts_gcs_path.txt'),
-        test_data='android-cts-5.1_r5-linux_x86-arm.zip')
-    _CTS_XML_TESTCASE_ELEMENTS = ('./TestPackage/TestSuite[@name="android"]/'
-                                  'TestSuite[@name="webkit"]/'
-                                  'TestSuite[@name="cts"]/TestCase')
-    self_result = self.m.step.active_result
-    self_result.presentation.logs['cts_file_name'] = [_cts_file_name]
-    _cts_file_name = _cts_file_name.strip()
-    # WebView user agent is changed, and new CTS hasn't been published to
-    # reflect that.
+    cts_filenames_json = self.m.file.read(
+        'Fetch CTS filename data',
+        _CTS_CONFIG_SRC_PATH.join('webview_cts_gcs_path.json'),
+        test_data='''
+                      {
+                        "arm_64": {
+                          "L": "cts_arm64_L.zip"
+                        }
+                      }''')
+    cts_filenames = self.m.json.loads(cts_filenames_json)
+    try:
+      cts_filename = cts_filenames[arch][android_platform]
+    except KeyError:
+      raise self.m.step.StepFailure(
+          'No CTS test found to use for arch:%s android:%s' % (
+              arch, android_platform))
+
     expected_failure_json = self.m.file.read(
-        'Fetch the expected failures tests for CTS from chromium checkout',
+        'Fetch expected failures data',
         _CTS_CONFIG_SRC_PATH.join('expected_failure_on_bot.json'),
         test_data = '''
                         {
                           "android.webkit.cts.ExampleBlacklistedTest":
                             [
                               {
                                 "name": "testA",
                                 "_bug_id": "crbug.com/123"
                               },
                               {"name": "testB"}
                             ]
-                          }'''
-        )
+                          }''')
     expected_failure = self.m.json.loads(expected_failure_json)
 
     cts_base_dir = self.m.path['cache'].join('android_cts')
-    cts_zip_path = cts_base_dir.join(_cts_file_name)
+    cts_zip_path = cts_base_dir.join(cts_filename)
     cts_extract_dir = cts_base_dir.join('unzipped')
     if not self.m.path.exists(cts_zip_path):
       with self.m.step.nest('Update CTS'):
         # Remove all old cts files before downloading new one.
         self.m.file.rmtree('Delete old CTS', cts_base_dir)
         self.m.file.makedirs('Create CTS dir', cts_base_dir)
         self.m.gsutil.download(name='Download new CTS',
                                bucket='chromium-cts',
-                               source=_cts_file_name,
+                               source=cts_filename,
                                dest=cts_zip_path)
         self.m.zip.unzip(step_name='Extract new CTS',
                          zip_file=cts_zip_path,
                          output=cts_extract_dir)
 
     cts_path = cts_extract_dir.join('android-cts', 'tools', 'cts-tradefed')
     env = {'PATH': self.m.path.pathsep.join([self.m.adb.adb_dir(), '%(PATH)s'])}
 
     try:
       self.m.step('Run CTS%s' % suffix,
@@ skipping 15 matching lines @@
           if (len(split) > 1):
             return split[1]
       raise self.m.step.StepFailure(
           "Failed to parse the CTS output for the xml report file location")
 
     report_xml = self.m.file.read('Read test result and report failures',
                                   find_test_report_html(result.stdout))
     root = ElementTree.fromstring(report_xml)
     not_executed_tests = []
     unexpected_test_failures = []
+
+    _CTS_XML_TESTCASE_ELEMENTS = ('./TestPackage/TestSuite[@name="android"]/'
+                                  'TestSuite[@name="webkit"]/'
+                                  'TestSuite[@name="cts"]/TestCase')
     test_classes = root.findall(_CTS_XML_TESTCASE_ELEMENTS)
 
     for test_class in test_classes:
       class_name = 'android.webkit.cts.%s' % test_class.get('name')
       test_methods = test_class.findall('./Test')
 
       for test_method in test_methods:
         method_name = '%s#%s' % (class_name, test_method.get('name'))
         if test_method.get('result') == 'notExecuted':
           not_executed_tests.append(method_name)
@@ skipping 225 matching lines @@
       script = self.c.test_runner
       if wrapper_script_suite_name:
         script = self.m.chromium.output_dir.join('bin', 'run_%s' %
                                                  wrapper_script_suite_name)
       else:
         env = kwargs.get('env', {})
         env['CHROMIUM_OUTPUT_DIR'] = env.get('CHROMIUM_OUTPUT_DIR',
                                              self.m.chromium.output_dir)
         kwargs['env'] = env
       return self.m.python(step_name, script, args, **kwargs)