Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2202853003: Adding platform specific CTS tests. (Closed)

Created:
4 years, 4 months ago by mikecase (-- gone --)
Modified:
4 years, 4 months ago
Reviewers:
the real yoland
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding platform specific CTS tests. We should be running CTS tests on the platform they were built for. Currently, we just run the L CTS tests everywhere. Changing the webview_cts_gcs_path file to json, and will add CTS zips for each platform we are interested in running tests on. BUG=633739 Committed: https://crrev.com/6fc6c1e68eb8bda9e79bfbc472499074e64c000f Cr-Commit-Position: refs/heads/master@{#410115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M android_webview/tools/cts_config/expected_failure_on_bot.json View 1 chunk +1 line, -1 line 0 comments Download
A android_webview/tools/cts_config/webview_cts_gcs_path.json View 1 chunk +5 lines, -0 lines 0 comments Download
D android_webview/tools/cts_config/webview_cts_gcs_path.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mikecase (-- gone --)
What do you think of doing something like this? If I land this, Ill have ...
4 years, 4 months ago (2016-08-02 22:28:20 UTC) #2
the real yoland
lgtm
4 years, 4 months ago (2016-08-03 23:45:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202853003/1
4 years, 4 months ago (2016-08-05 17:36:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 18:23:15 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:25:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fc6c1e68eb8bda9e79bfbc472499074e64c000f
Cr-Commit-Position: refs/heads/master@{#410115}

Powered by Google App Engine
This is Rietveld 408576698