scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json - Issue 2206113002: [WebView] Update CTS logic to load test name from json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json

Issue 2206113002: [WebView] Update CTS logic to load test name from json. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: [WebView] Update CTS logic to load test name from json. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_android/api.py ('K') | « scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_expected_failure.json ('k') | scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_platform.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json

diff --git a/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json b/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json

index c9df512409405ea91a23674306274bf1a3d46f65..458c85c9bcd35e184207714e6a92969a19f04a47 100644

--- a/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json

+++ b/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json

@@ -841,14 +841,10 @@

"python",

"-u",

"\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

- "[SLAVE_BUILD]/src/android_webview/tools/cts_config/webview_cts_gcs_path.txt",

+ "[SLAVE_BUILD]/src/android_webview/tools/cts_config/webview_cts_gcs_path.json",

"/path/to/tmp/"

- "name": "Fetch for the name of the cts file",

- "~followup_annotations": [

- "@@@STEP_LOG_LINE@cts_file_name@android-cts-5.1_r5-linux_x86-arm.zip@@@",

- "@@@STEP_LOG_END@cts_file_name@@@"

- ]

+ "name": "Fetch CTS filename data"

{

"cmd": [

@@ -858,7 +854,7 @@

"[SLAVE_BUILD]/src/android_webview/tools/cts_config/expected_failure_on_bot.json",

"/path/to/tmp/"

- "name": "Fetch the expected failures tests for CTS from chromium checkout"

+ "name": "Fetch expected failures data"

{

"cmd": [],

@@ -916,8 +912,8 @@

"RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

"----",

"cp",

- "gs://chromium-cts/android-cts-5.1_r5-linux_x86-arm.zip",

- "[CACHE]/android_cts/android-cts-5.1_r5-linux_x86-arm.zip"

+ "gs://chromium-cts/cts_arm64_L.zip",

+ "[CACHE]/android_cts/cts_arm64_L.zip"

"name": "Update CTS.gsutil Download new CTS",

"~followup_annotations": [

@@ -931,7 +927,7 @@

"RECIPE_MODULE[build::zip]/resources/unzip.py"

"name": "Update CTS.Extract new CTS",

- "stdin": "{\"output\": \"[CACHE]/android_cts/unzipped\", \"zip_file\": \"[CACHE]/android_cts/android-cts-5.1_r5-linux_x86-arm.zip\"}",

+ "stdin": "{\"output\": \"[CACHE]/android_cts/unzipped\", \"zip_file\": \"[CACHE]/android_cts/cts_arm64_L.zip\"}",

"~followup_annotations": [

"@@@STEP_NEST_LEVEL@1@@@"

]