Change SSLStatus to carry a vector of SCT statuses instead of counters

Change SSLStatus to carry a vector of SCT statuses instead of counters

SSLStatus consumers only care about the number of SCTs with different
statuses, so previously SSLStatus exposed counters: |num_invalid_scts|,
|num_unknown_scts|, and |num_valid_scts|.

However, in seeking to add a new type of SCT validation status, it
became clear that this design is a bit messy: the layers between the
net stack and the UI code that consumes the status have to know about
all the possible validation statuses. Moreover, we take a list of SCTs
and tally them up by status, only to convert those tallies back into a
list of statuses. So instead, I've changed SSLStatus to hold a vector
of SCTVerifyStatus enums, instead of counters for each possible status.

Also note that connections typically have no more than 3 or 4 SCTs, so
keeping a vector of SCTVerifyStatus instead of counters will not use a
whole lot more memory.

This change is based on top of https://codereview.chromium.org/2208803002/.

BUG=634006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/41b454d9282c8dca0800b1d07dee9f38d99b3403
Cr-Commit-Position: refs/heads/master@{#409721}

[estark, 2016-08-03 20:49:00]

Description was changed from

==========
Change SSLStatus to carry a vector of SCT statuses instead of counters

SSLStatus consumers only care about the number of SCTs with different
statuses, so previously SSLStatus exposed counters: |num_invalid_scts|,
|num_unknown_scts|, and |num_valid_scts|.

However, in seeking to add a new type of SCT validation status, it
became clear that this design is a bit messy: all the layers between the
net stack and the UI code that consumes the status have to know about
all the possible validation statuses. So instead, I've changed SSLStatus
to hold a vector of SCTVerifyStatus enums, instead of counters for each
possible status.

Also note that connections typically have no more than 3 or 4 SCTs, so
keeping a vector of SCTVerifyStatus instead of counters will not use a
whole lot more memory.

This change is based on top of https://codereview.chromium.org/2208803002/.

BUG=634006
==========

to

==========
Change SSLStatus to carry a vector of SCT statuses instead of counters

SSLStatus consumers only care about the number of SCTs with different
statuses, so previously SSLStatus exposed counters: |num_invalid_scts|,
|num_unknown_scts|, and |num_valid_scts|.

However, in seeking to add a new type of SCT validation status, it
became clear that this design is a bit messy: all the layers between the
net stack and the UI code that consumes the status have to know about
all the possible validation statuses. So instead, I've changed SSLStatus
to hold a vector of SCTVerifyStatus enums, instead of counters for each
possible status.

Also note that connections typically have no more than 3 or 4 SCTs, so
keeping a vector of SCTVerifyStatus instead of counters will not use a
whole lot more memory.

This change is based on top of https://codereview.chromium.org/2208803002/.

BUG=634006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[estark, 2016-08-03 21:18:26]

Description was changed from

==========
Change SSLStatus to carry a vector of SCT statuses instead of counters

SSLStatus consumers only care about the number of SCTs with different
statuses, so previously SSLStatus exposed counters: |num_invalid_scts|,
|num_unknown_scts|, and |num_valid_scts|.

However, in seeking to add a new type of SCT validation status, it
became clear that this design is a bit messy: all the layers between the
net stack and the UI code that consumes the status have to know about
all the possible validation statuses. So instead, I've changed SSLStatus
to hold a vector of SCTVerifyStatus enums, instead of counters for each
possible status.

Also note that connections typically have no more than 3 or 4 SCTs, so
keeping a vector of SCTVerifyStatus instead of counters will not use a
whole lot more memory.

This change is based on top of https://codereview.chromium.org/2208803002/.

BUG=634006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change SSLStatus to carry a vector of SCT statuses instead of counters

SSLStatus consumers only care about the number of SCTs with different
statuses, so previously SSLStatus exposed counters: |num_invalid_scts|,
|num_unknown_scts|, and |num_valid_scts|.

However, in seeking to add a new type of SCT validation status, it
became clear that this design is a bit messy: the layers between the
net stack and the UI code that consumes the status have to know about
all the possible validation statuses. Moreover, we take a list of SCTs
and tally them up by status, only to convert those tallies back into a
list of statuses. So instead, I've changed SSLStatus to hold a vector
of SCTVerifyStatus enums, instead of counters for each possible status.

Also note that connections typically have no more than 3 or 4 SCTs, so
keeping a vector of SCTVerifyStatus instead of counters will not use a
whole lot more memory.

This change is based on top of https://codereview.chromium.org/2208803002/.

BUG=634006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[estark, 2016-08-03 23:44:36]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 23:44:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-08-03 23:48:23]

estark@chromium.org changed reviewers:
+ jam@chromium.org

[estark, 2016-08-03 23:48:24]

jam, this isn't particularly related to what you've been doing but since you
have SSLStatus on the brain, could you please take a look at this CL?

https://codereview.chromium.org/2206093004/diff/1/chrome/browser/ssl/chrome_s...
File chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
(right):

https://codereview.chromium.org/2206093004/diff/1/chrome/browser/ssl/chrome_s...
chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc:1119: 
Unfortunately a lot of the code from here down is duplicated boilerplate from
the test above. Couldn't see an easy way to reduce the boilerplate, but open to
suggestions.

[commit-bot: I haz the power, 2016-08-04 01:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:24:35]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[jam, 2016-08-04 01:38:14]

lgtm

(re the test, imo it's fine to have duplication there)

[estark, 2016-08-04 04:24:26]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-08-04 04:24:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 05:10:27]

Description was changed from

==========
Change SSLStatus to carry a vector of SCT statuses instead of counters

SSLStatus consumers only care about the number of SCTs with different
statuses, so previously SSLStatus exposed counters: |num_invalid_scts|,
|num_unknown_scts|, and |num_valid_scts|.

However, in seeking to add a new type of SCT validation status, it
became clear that this design is a bit messy: the layers between the
net stack and the UI code that consumes the status have to know about
all the possible validation statuses. Moreover, we take a list of SCTs
and tally them up by status, only to convert those tallies back into a
list of statuses. So instead, I've changed SSLStatus to hold a vector
of SCTVerifyStatus enums, instead of counters for each possible status.

Also note that connections typically have no more than 3 or 4 SCTs, so
keeping a vector of SCTVerifyStatus instead of counters will not use a
whole lot more memory.

This change is based on top of https://codereview.chromium.org/2208803002/.

BUG=634006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change SSLStatus to carry a vector of SCT statuses instead of counters

SSLStatus consumers only care about the number of SCTs with different
statuses, so previously SSLStatus exposed counters: |num_invalid_scts|,
|num_unknown_scts|, and |num_valid_scts|.

However, in seeking to add a new type of SCT validation status, it
became clear that this design is a bit messy: the layers between the
net stack and the UI code that consumes the status have to know about
all the possible validation statuses. Moreover, we take a list of SCTs
and tally them up by status, only to convert those tallies back into a
list of statuses. So instead, I've changed SSLStatus to hold a vector
of SCTVerifyStatus enums, instead of counters for each possible status.

Also note that connections typically have no more than 3 or 4 SCTs, so
keeping a vector of SCTVerifyStatus instead of counters will not use a
whole lot more memory.

This change is based on top of https://codereview.chromium.org/2208803002/.

BUG=634006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-08-04 05:10:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-04 05:12:37]

Description was changed from

==========
Change SSLStatus to carry a vector of SCT statuses instead of counters

SSLStatus consumers only care about the number of SCTs with different
statuses, so previously SSLStatus exposed counters: |num_invalid_scts|,
|num_unknown_scts|, and |num_valid_scts|.

However, in seeking to add a new type of SCT validation status, it
became clear that this design is a bit messy: the layers between the
net stack and the UI code that consumes the status have to know about
all the possible validation statuses. Moreover, we take a list of SCTs
and tally them up by status, only to convert those tallies back into a
list of statuses. So instead, I've changed SSLStatus to hold a vector
of SCTVerifyStatus enums, instead of counters for each possible status.

Also note that connections typically have no more than 3 or 4 SCTs, so
keeping a vector of SCTVerifyStatus instead of counters will not use a
whole lot more memory.

This change is based on top of https://codereview.chromium.org/2208803002/.

BUG=634006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change SSLStatus to carry a vector of SCT statuses instead of counters

SSLStatus consumers only care about the number of SCTs with different
statuses, so previously SSLStatus exposed counters: |num_invalid_scts|,
|num_unknown_scts|, and |num_valid_scts|.

However, in seeking to add a new type of SCT validation status, it
became clear that this design is a bit messy: the layers between the
net stack and the UI code that consumes the status have to know about
all the possible validation statuses. Moreover, we take a list of SCTs
and tally them up by status, only to convert those tallies back into a
list of statuses. So instead, I've changed SSLStatus to hold a vector
of SCTVerifyStatus enums, instead of counters for each possible status.

Also note that connections typically have no more than 3 or 4 SCTs, so
keeping a vector of SCTVerifyStatus instead of counters will not use a
whole lot more memory.

This change is based on top of https://codereview.chromium.org/2208803002/.

BUG=634006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/41b454d9282c8dca0800b1d07dee9f38d99b3403
Cr-Commit-Position: refs/heads/master@{#409721}
==========

[commit-bot: I haz the power, 2016-08-04 05:12:38]

Patchset 1 (id:??) landed as
https://crrev.com/41b454d9282c8dca0800b1d07dee9f38d99b3403
Cr-Commit-Position: refs/heads/master@{#409721}