Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: content/public/common/ssl_status.cc

Issue 2206093004: Change SSLStatus to carry a vector of SCT statuses instead of counters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/ssl_status.cc
diff --git a/content/public/common/ssl_status.cc b/content/public/common/ssl_status.cc
index 709f4188a2610c20083f79f29beac64d93d1fa2e..aedcc519542e985e18930fd4f41347c0fa663aae 100644
--- a/content/public/common/ssl_status.cc
+++ b/content/public/common/ssl_status.cc
@@ -17,9 +17,6 @@ SSLStatus::SSLStatus()
key_exchange_info(0),
connection_status(0),
content_status(NORMAL_CONTENT),
- num_unknown_scts(0),
- num_invalid_scts(0),
- num_valid_scts(0),
pkp_bypassed(false) {}
SSLStatus::SSLStatus(SecurityStyle security_style,
@@ -32,29 +29,9 @@ SSLStatus::SSLStatus(SecurityStyle security_style,
key_exchange_info(ssl_info.key_exchange_info),
connection_status(ssl_info.connection_status),
content_status(NORMAL_CONTENT),
- num_unknown_scts(0),
- num_invalid_scts(0),
- num_valid_scts(0),
pkp_bypassed(ssl_info.pkp_bypassed) {
- // Count unknown, invalid and valid SCTs.
for (const auto& sct_and_status : ssl_info.signed_certificate_timestamps) {
- switch (sct_and_status.status) {
- case net::ct::SCT_STATUS_LOG_UNKNOWN:
- num_unknown_scts++;
- break;
- case net::ct::SCT_STATUS_INVALID:
- num_invalid_scts++;
- break;
- case net::ct::SCT_STATUS_OK:
- num_valid_scts++;
- break;
- case net::ct::SCT_STATUS_NONE:
- case net::ct::SCT_STATUS_MAX:
- // These enum values do not represent SCTs that are taken into account
- // for CT compliance calculations, so we ignore them.
- NOTREACHED();
- break;
- }
+ sct_statuses.push_back(sct_and_status.status);
}
}

Powered by Google App Engine
This is Rietveld 408576698