Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2123)

Unified Diff: content/public/common/ssl_status.h

Issue 2206093004: Change SSLStatus to carry a vector of SCT statuses instead of counters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/ssl_status.h
diff --git a/content/public/common/ssl_status.h b/content/public/common/ssl_status.h
index 8233da77200cd9f2a926d7dc1be88c5856218f95..e8e6ab7c29080273244890f34340e00dc749a210 100644
--- a/content/public/common/ssl_status.h
+++ b/content/public/common/ssl_status.h
@@ -5,9 +5,12 @@
#ifndef CONTENT_PUBLIC_COMMON_SSL_STATUS_H_
#define CONTENT_PUBLIC_COMMON_SSL_STATUS_H_
+#include <vector>
+
#include "content/common/content_export.h"
#include "content/public/common/security_style.h"
#include "net/cert/cert_status_flags.h"
+#include "net/cert/sct_status_flags.h"
namespace net {
class SSLInfo;
@@ -46,9 +49,7 @@ struct CONTENT_EXPORT SSLStatus {
key_exchange_info == status.key_exchange_info &&
connection_status == status.connection_status &&
content_status == status.content_status &&
- num_unknown_scts == status.num_unknown_scts &&
- num_invalid_scts == status.num_invalid_scts &&
- num_valid_scts == status.num_valid_scts &&
+ sct_statuses == status.sct_statuses &&
pkp_bypassed == status.pkp_bypassed;
}
@@ -61,10 +62,10 @@ struct CONTENT_EXPORT SSLStatus {
int connection_status;
// A combination of the ContentStatusFlags above.
int content_status;
- // Signed Certificate Timestamps (SCTs) of Certificate Transparency (CT).
- uint32_t num_unknown_scts;
- uint32_t num_invalid_scts;
- uint32_t num_valid_scts;
+ // The validation statuses of the Signed Certificate Timestamps (SCTs)
+ // of Certificate Transparency (CT) that were served with the
+ // main resource.
+ std::vector<net::ct::SCTVerifyStatus> sct_statuses;
// True if PKP was bypassed due to a local trust anchor.
bool pkp_bypassed;
};

Powered by Google App Engine
This is Rietveld 408576698