Change SSLStatus to carry a vector of SCT statuses instead of counters

content/common/ssl_status_serialization_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/ssl_status_serialization.h"
 
 #include "net/ssl/ssl_connection_status_flags.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace content {
 
 namespace {
 
 void SetTestStatus(SSLStatus* status) {
   status->security_style = SECURITY_STYLE_AUTHENTICATED;
   status->cert_id = 1;
   status->cert_status = net::CERT_STATUS_DATE_INVALID;
   status->security_bits = 80;
   status->key_exchange_info = 23;
   status->connection_status = net::SSL_CONNECTION_VERSION_TLS1_2;
-  status->num_unknown_scts = 0;
-  status->num_invalid_scts = 0;
-  status->num_valid_scts = 1;
+  status->sct_statuses.push_back(net::ct::SCT_STATUS_OK);
 }
 
 bool SSLStatusAreEqual(const SSLStatus& a, const SSLStatus &b) {
   return a.Equals(b);
 }
 
 } // namespace
 
 std::ostream& operator<<(std::ostream& os, const SSLStatus& status) {
   return os << "Security Style: " << status.security_style
             << "\nCert ID: " << status.cert_id
             << "\nCert Status: " << status.cert_status
             << "\nSecurity bits: " << status.security_bits
             << "\nKey exchange info: " << status.key_exchange_info
             << "\nConnection status: " << status.connection_status
             << "\nContent Status: " << status.content_status
-            << "\nNumber of unknown SCTs: " << status.num_unknown_scts
-            << "\nNumber of invalid SCTs: " << status.num_invalid_scts
-            << "\nNumber of valid SCTs: " << status.num_valid_scts;
+            << "\nNumber of SCTs: " << status.sct_statuses.size();
 }
 
 // Test that a valid serialized SSLStatus returns true on
 // deserialization and deserializes correctly.
 TEST(SSLStatusSerializationTest, DeserializeSerializedStatus) {
   // Serialize dummy data and test that it deserializes properly.
   SSLStatus status;
   SetTestStatus(&status);
   std::string serialized = SerializeSecurityInfo(status);
 
@@ skipping 49 matching lines @@
   SSLStatus status;
   SetTestStatus(&status);
   status.security_style = static_cast<SecurityStyle>(100);
   std::string serialized = SerializeSecurityInfo(status);
 
   SSLStatus invalid_deserialized;
   ASSERT_FALSE(DeserializeSecurityInfo(serialized, &invalid_deserialized));
   EXPECT_PRED2(SSLStatusAreEqual, SSLStatus(), invalid_deserialized);
 }
 
+// Serialize a status with an empty |sct_statuses| field and test that
+// deserializing works.
+TEST(SSLStatusSerializationTest, DeserializeEmptySCTStatuses) {
+  SSLStatus status;
+  SetTestStatus(&status);
+  status.sct_statuses.clear();
+  std::string serialized = SerializeSecurityInfo(status);
+
+  SSLStatus deserialized;
+  ASSERT_TRUE(DeserializeSecurityInfo(serialized, &deserialized));
+  EXPECT_PRED2(SSLStatusAreEqual, status, deserialized);
+}
+
+// Serialize a status with multiple different |sct_statuses| and test that
+// deserializing works.
+TEST(SSLStatusSerializationTest, DeserializeMultipleSCTStatuses) {
+  SSLStatus status;
+  SetTestStatus(&status);
+  status.sct_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN);
+  status.sct_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN);
+  status.sct_statuses.push_back(net::ct::SCT_STATUS_OK);
+  status.sct_statuses.push_back(net::ct::SCT_STATUS_INVALID);
+  std::string serialized = SerializeSecurityInfo(status);
+
+  SSLStatus deserialized;
+  ASSERT_TRUE(DeserializeSecurityInfo(serialized, &deserialized));
+  EXPECT_PRED2(SSLStatusAreEqual, status, deserialized);
+}
+
+// Serialize a status with a bad SCTVerifyStatus value and test that
+// deserializing it fails.
+TEST(SSLStatusSerializationTest, DeserializeBogusSCTVerifyStatus) {
+  SSLStatus status;
+  SetTestStatus(&status);
+  status.sct_statuses.push_back(static_cast<net::ct::SCTVerifyStatus>(100));
+  std::string serialized = SerializeSecurityInfo(status);
+
+  SSLStatus deserialized;
+  ASSERT_FALSE(DeserializeSecurityInfo(serialized, &deserialized));
+  EXPECT_PRED2(SSLStatusAreEqual, SSLStatus(), deserialized);
+}
+
 }  // namespace