third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp - Issue 2205913002: [DevTools] Split a part of V8Inspector into V8Debugger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

Issue 2205913002: [DevTools] Split a part of V8Inspector into V8Debugger. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-inspector-rename

Patch Set: context scope! Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

index f440c73016fa9315cb19c71a185b78583fce992a..037d91036cfde855929d872547f885e08063f6cf 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

@@ -165,6 +165,11 @@ v8::Local<v8::String> toV8StringInternalized(v8::Isolate* isolate, const String1

return v8::String::NewFromTwoByte(isolate, reinterpret_cast<const uint16_t*>(string.characters16()), v8::NewStringType::kInternalized, string.length()).ToLocalChecked();

}

+v8::Local<v8::String> toV8StringInternalized(v8::Isolate* isolate, const char* str)

+ return v8::String::NewFromUtf8(isolate, str, v8::NewStringType::kInternalized).ToLocalChecked();

String16 toProtocolString(v8::Local<v8::String> value)

{

if (value.IsEmpty() || value->IsNull() || value->IsUndefined())