third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h - Issue 2205913002: [DevTools] Split a part of V8Inspector into V8Debugger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

Issue 2205913002: [DevTools] Split a part of V8Inspector into V8Debugger. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-inspector-rename

Patch Set: context scope! Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

index 2f92d07009fb66865abde60781aed4a71cf794de..3d7e71b5296f03a48ddb1d5d4f0499b836bfe5e7 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

@@ -15,7 +15,7 @@

namespace blink {

class TracedValue;

-class V8InspectorImpl;

+class V8Debugger;

// Note: async stack trace may have empty top stack with non-empty tail to indicate

// that current native-only state had some async story.

@@ -51,14 +51,14 @@ public:

};

static void setCaptureStackTraceForUncaughtExceptions(v8::Isolate*, bool capture);

- static std::unique_ptr<V8StackTraceImpl> create(V8InspectorImpl*, int contextGroupId, v8::Local<v8::StackTrace>, size_t maxStackSize, const String16& description = String16());

- static std::unique_ptr<V8StackTraceImpl> capture(V8InspectorImpl*, int contextGroupId, size_t maxStackSize, const String16& description = String16());

+ static std::unique_ptr<V8StackTraceImpl> create(V8Debugger*, int contextGroupId, v8::Local<v8::StackTrace>, size_t maxStackSize, const String16& description = String16());

+ static std::unique_ptr<V8StackTraceImpl> capture(V8Debugger*, int contextGroupId, size_t maxStackSize, const String16& description = String16());

std::unique_ptr<V8StackTrace> clone() override;

std::unique_ptr<V8StackTraceImpl> cloneImpl();

std::unique_ptr<V8StackTrace> isolatedCopy() override;

std::unique_ptr<V8StackTraceImpl> isolatedCopyImpl();

- std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectForTail(V8InspectorImpl*) const;

+ std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectForTail(V8Debugger*) const;

std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectImpl() const;

~V8StackTraceImpl() override;