Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2205123003: DevTools: introduce view locations, allow opening views by id. (Closed)

Created:
4 years, 4 months ago by pfeldman
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: introduce view locations, allow opening views by id. BUG=634145 Committed: https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711 Cr-Commit-Position: refs/heads/master@{#409654}

Patch Set 1 #

Patch Set 2 : review comments addressed #

Patch Set 3 : test fixed #

Total comments: 8

Patch Set 4 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -278 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-enabled/tabbed-pane-closeable-persistence-restore.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/animation/animation-empty-web-animations.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/animation/animation-timeline.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/animation/animation-web-anim-negative-start-time.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/module.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Console.js View 2 chunks +1 line, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/module.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devices/module.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 3 chunks +2 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 8 chunks +36 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/module.json View 1 6 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 4 chunks +14 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 7 chunks +26 lines, -6 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/Drawer.js View 1 chunk +0 lines, -95 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 7 chunks +43 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 4 chunks +7 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/ui/View.js View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Widget.js View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
pfeldman
4 years, 4 months ago (2016-08-03 01:14:48 UTC) #2
pfeldman
PTAL
4 years, 4 months ago (2016-08-03 18:17:06 UTC) #3
dgozman
lgtm https://codereview.chromium.org/2205123003/diff/40001/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js File third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js (right): https://codereview.chromium.org/2205123003/diff/40001/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js#newcode80 third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js:80: resolveLocation: function(locationName) I thought we agreed on revealLocation. ...
4 years, 4 months ago (2016-08-03 19:18:19 UTC) #8
pfeldman
https://codereview.chromium.org/2205123003/diff/40001/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js File third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js (right): https://codereview.chromium.org/2205123003/diff/40001/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js#newcode80 third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js:80: resolveLocation: function(locationName) On 2016/08/03 19:18:18, dgozman wrote: > I ...
4 years, 4 months ago (2016-08-03 21:52:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205123003/60001
4 years, 4 months ago (2016-08-03 21:55:56 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-03 23:11:25 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 23:13:21 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711
Cr-Commit-Position: refs/heads/master@{#409654}

Powered by Google App Engine
This is Rietveld 408576698