third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html - Issue 2205123003: DevTools: introduce view locations, allow opening views by id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html

Issue 2205123003: DevTools: introduce view locations, allow opening views by id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/animation/animation-web-anim-negative-start-time.html ('k') | third_party/WebKit/Source/devtools/devtools.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html b/third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html

index 352a7f9213df3cdcc5cff9b8f5b376d85aa3b91c..c22f5f6b681dc737d411f4cbeb0f73062c9b2317 100644

--- a/third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html

+++ b/third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html

@@ -9,18 +9,18 @@ var test = function()

InspectorTest.addResult("Closeable tabs to restore: " + JSON.stringify(tabbedPaneController._closeableTabSetting.get()));

}

- var tabbedPaneController = WebInspector.inspectorView._drawer._extensibleTabbedPane;

+ var tabbedPaneController = WebInspector.inspectorView._drawerTabbedPane;

logPersistenceSetting();

// Show a closeable tab.

- tabbedPaneController.showTab("sensors");

+ tabbedPaneController.showView("sensors");

logPersistenceSetting();

- tabbedPaneController.showTab("sensors");

+ tabbedPaneController.showView("sensors");

logPersistenceSetting();

// Show a permanent tab.

- tabbedPaneController.showTab("console");

+ tabbedPaneController.showView("console");

logPersistenceSetting();

// Show temporary tab.

- tabbedPaneController.showTab("sources.history");

+ tabbedPaneController.showView("sources.history");

logPersistenceSetting();

// Close closeable tab.

tabbedPaneController._tabbedPane.closeTab("sensors");