third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js - Issue 2205123003: DevTools: introduce view locations, allow opening views by id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

Issue 2205123003: DevTools: introduce view locations, allow opening views by id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/settings/module.json ('k') | third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js b/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

index 8917f2dc9be2148b9bd2a311c133e88ede4972d0..92b851fa777324883cdf7f809afbbff607a41433 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

@@ -350,7 +350,7 @@ WebInspector.AdvancedSearchView.prototype = {

WebInspector.AdvancedSearchView.openSearch = function(query, filePath)

{

- WebInspector.inspectorView.showViewInDrawer("sources.search");

+ WebInspector.viewManager.showView("sources.search");

var searchView = /** @type {!WebInspector.AdvancedSearchView} */ (self.runtime.sharedInstance(WebInspector.AdvancedSearchView));

var fileMask = filePath ? " file:" + filePath : "";

searchView._toggle(query + fileMask);