third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js - Issue 2205123003: DevTools: introduce view locations, allow opening views by id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

Issue 2205123003: DevTools: introduce view locations, allow opening views by id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

index 1b4a88b67f7a19ac1bff6502f90b17cd4974edbf..1c7d905455e9a5172eaee7d9241a6fc43c273cf3 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

@@ -332,8 +332,8 @@ WebInspector.CommandMenu.createRevealPanelCommand = function(extension)

WebInspector.CommandMenu.createRevealDrawerCommand = function(extension)

{

- var drawerId = extension.descriptor()["name"];

- var executeHandler = WebInspector.inspectorView.showViewInDrawer.bind(WebInspector.inspectorView, drawerId);

+ var drawerId = extension.descriptor()["id"];

+ var executeHandler = WebInspector.viewManager.showView.bind(WebInspector.viewManager, drawerId);

var tags = extension.descriptor()["tags"] || "";

return WebInspector.CommandMenu.createCommand(WebInspector.UIString("Drawer"), tags, WebInspector.UIString("Show %s", extension.title()), "", executeHandler);

}

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/module.json ('k') | no next file » | no next file with comments »