Whittle down some compositing chicken/egg hacks

Whittle down some compositing chicken/egg hacks

These chicken/egg hacks appear to only be needed for scroll parts. This CL
moves them into RenderLayerScrollableArea so that we don't need to apply them
constantly for RenderLayers that aren't scrollable.

R=ojan@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170522

[ojan, 2014-04-01 01:54:10]

lgtm

[commit-bot: I haz the power, 2014-04-01 01:54:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/220473002/20001

[commit-bot: I haz the power, 2014-04-01 01:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 01:54:25]

Failed to apply patch for
Source/core/rendering/compositing/RenderLayerCompositor.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/compositing/RenderLayerCompositor.cpp
  Hunk #1 FAILED at 816.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/rendering/compositing/RenderLayerCompositor.cpp.rej

Patch:       Source/core/rendering/compositing/RenderLayerCompositor.cpp
Index: Source/core/rendering/compositing/RenderLayerCompositor.cpp
diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.cpp
b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
index
160d7cf8f42114178155617360910992507f6f2f..d05703fa28c13bc9c7301cf6559edf485d92e09a
100644
--- a/Source/core/rendering/compositing/RenderLayerCompositor.cpp
+++ b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
@@ -816,13 +816,8 @@ RenderLayerCompositor::CompositingStateTransitionType
RenderLayerCompositor::com
 // See crbug.com/339892 for a list of tests that fail if this method is
removed.
 void
RenderLayerCompositor::applyUpdateLayerCompositingStateChickenEggHacks(RenderLayer*
layer, CompositingStateTransitionType compositedLayerUpdate)
 {
-    // See if we need content or clipping layers. Methods called here should
assume
-    // that the compositing state of descendant layers has not been updated
yet.
-    if (layer->hasCompositedLayerMapping() &&
layer->compositedLayerMapping()->updateGraphicsLayerConfiguration(GraphicsLayerUpdater::ForceUpdate))
-        setCompositingLayersNeedRebuild();
-
     if (compositedLayerUpdate != NoCompositingStateChange)
-        allocateOrClearCompositedLayerMapping(layer,
computeCompositedLayerUpdate(layer));
+        allocateOrClearCompositedLayerMapping(layer, compositedLayerUpdate);
 }
 
 void RenderLayerCompositor::updateLayerCompositingState(RenderLayer* layer,
UpdateLayerCompositingStateOptions options)

[abarth-chromium, 2014-04-01 01:54:58]

This CL depends on https://codereview.chromium.org/220193003/

[abarth-chromium, 2014-04-01 05:06:52]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-04-01 05:06:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/220473002/20001

[commit-bot: I haz the power, 2014-04-01 06:11:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 06:11:44]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[abarth-chromium, 2014-04-01 06:16:00]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-04-01 06:16:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/220473002/40001

[commit-bot: I haz the power, 2014-04-01 07:19:21]

Change committed as 170522