Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 220473002: Whittle down some compositing chicken/egg hacks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Hopefully fix assrt Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayerScrollableArea.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 800 matching lines...) Expand 10 before | Expand all | Expand 10 after
811 } 811 }
812 } 812 }
813 } 813 }
814 return update; 814 return update;
815 } 815 }
816 816
817 // These are temporary hacks to work around chicken-egg issues while we continue to refactor the compositing code. 817 // These are temporary hacks to work around chicken-egg issues while we continue to refactor the compositing code.
818 // See crbug.com/339892 for a list of tests that fail if this method is removed. 818 // See crbug.com/339892 for a list of tests that fail if this method is removed.
819 void RenderLayerCompositor::applyUpdateLayerCompositingStateChickenEggHacks(Rend erLayer* layer, CompositingStateTransitionType compositedLayerUpdate) 819 void RenderLayerCompositor::applyUpdateLayerCompositingStateChickenEggHacks(Rend erLayer* layer, CompositingStateTransitionType compositedLayerUpdate)
820 { 820 {
821 // See if we need content or clipping layers. Methods called here should ass ume
822 // that the compositing state of descendant layers has not been updated yet.
823 if (layer->hasCompositedLayerMapping() && layer->compositedLayerMapping()->u pdateGraphicsLayerConfiguration(GraphicsLayerUpdater::ForceUpdate))
824 setCompositingLayersNeedRebuild();
825
826 if (compositedLayerUpdate != NoCompositingStateChange) 821 if (compositedLayerUpdate != NoCompositingStateChange)
827 allocateOrClearCompositedLayerMapping(layer, computeCompositedLayerUpdat e(layer)); 822 allocateOrClearCompositedLayerMapping(layer, compositedLayerUpdate);
828 } 823 }
829 824
830 void RenderLayerCompositor::updateLayerCompositingState(RenderLayer* layer, Upda teLayerCompositingStateOptions options) 825 void RenderLayerCompositor::updateLayerCompositingState(RenderLayer* layer, Upda teLayerCompositingStateOptions options)
831 { 826 {
832 updateDirectCompositingReasons(layer); 827 updateDirectCompositingReasons(layer);
833 CompositingStateTransitionType compositedLayerUpdate = computeCompositedLaye rUpdate(layer); 828 CompositingStateTransitionType compositedLayerUpdate = computeCompositedLaye rUpdate(layer);
834 829
835 if (compositedLayerUpdate != NoCompositingStateChange) { 830 if (compositedLayerUpdate != NoCompositingStateChange) {
836 setCompositingLayersNeedRebuild(); 831 setCompositingLayersNeedRebuild();
837 setNeedsToRecomputeCompositingRequirements(); 832 setNeedsToRecomputeCompositingRequirements();
(...skipping 1311 matching lines...) Expand 10 before | Expand all | Expand 10 after
2149 } else if (graphicsLayer == m_scrollLayer.get()) { 2144 } else if (graphicsLayer == m_scrollLayer.get()) {
2150 name = "LocalFrame Scrolling Layer"; 2145 name = "LocalFrame Scrolling Layer";
2151 } else { 2146 } else {
2152 ASSERT_NOT_REACHED(); 2147 ASSERT_NOT_REACHED();
2153 } 2148 }
2154 2149
2155 return name; 2150 return name;
2156 } 2151 }
2157 2152
2158 } // namespace WebCore 2153 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayerScrollableArea.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698