Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 220473002: Whittle down some compositing chicken/egg hacks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Hopefully fix assrt Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 729 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 740
741 // FIXME: Need to detect a swap from custom to native scrollbars (and vice v ersa). 741 // FIXME: Need to detect a swap from custom to native scrollbars (and vice v ersa).
742 if (m_hBar) 742 if (m_hBar)
743 m_hBar->styleChanged(); 743 m_hBar->styleChanged();
744 if (m_vBar) 744 if (m_vBar)
745 m_vBar->styleChanged(); 745 m_vBar->styleChanged();
746 746
747 updateScrollCornerStyle(); 747 updateScrollCornerStyle();
748 updateResizerAreaSet(); 748 updateResizerAreaSet();
749 updateResizerStyle(); 749 updateResizerStyle();
750
751 // FIXME: Remove incremental compositing updates after fixing the chicken/eg g issues
752 // https://code.google.com/p/chromium/issues/detail?id=343756
753 DisableCompositingQueryAsserts disabler;
754 RenderLayer* layer = this->layer();
755 if (layer->hasCompositedLayerMapping() && layer->compositedLayerMapping()->u pdateGraphicsLayerConfiguration(GraphicsLayerUpdater::ForceUpdate))
756 layer->compositor()->setCompositingLayersNeedRebuild();
750 } 757 }
751 758
752 IntSize RenderLayerScrollableArea::clampScrollOffset(const IntSize& scrollOffset ) const 759 IntSize RenderLayerScrollableArea::clampScrollOffset(const IntSize& scrollOffset ) const
753 { 760 {
754 int maxX = scrollWidth() - m_box->pixelSnappedClientWidth(); 761 int maxX = scrollWidth() - m_box->pixelSnappedClientWidth();
755 int maxY = scrollHeight() - m_box->pixelSnappedClientHeight(); 762 int maxY = scrollHeight() - m_box->pixelSnappedClientHeight();
756 763
757 int x = std::max(std::min(scrollOffset.width(), maxX), 0); 764 int x = std::max(std::min(scrollOffset.width(), maxX), 0);
758 int y = std::max(std::min(scrollOffset.height(), maxY), 0); 765 int y = std::max(std::min(scrollOffset.height(), maxY), 0);
759 return IntSize(x, y); 766 return IntSize(x, y);
(...skipping 785 matching lines...) Expand 10 before | Expand all | Expand 10 after
1545 void RenderLayerScrollableArea::setForceNeedsCompositedScrolling(ForceNeedsCompo sitedScrollingMode mode) 1552 void RenderLayerScrollableArea::setForceNeedsCompositedScrolling(ForceNeedsCompo sitedScrollingMode mode)
1546 { 1553 {
1547 if (m_forceNeedsCompositedScrolling == mode) 1554 if (m_forceNeedsCompositedScrolling == mode)
1548 return; 1555 return;
1549 1556
1550 m_forceNeedsCompositedScrolling = mode; 1557 m_forceNeedsCompositedScrolling = mode;
1551 layer()->didUpdateNeedsCompositedScrolling(); 1558 layer()->didUpdateNeedsCompositedScrolling();
1552 } 1559 }
1553 1560
1554 } // Namespace WebCore 1561 } // Namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698