mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization

mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization

BUG=626811
Committed: https://crrev.com/bd828670eaef26966373521fa23624d5b7b3ddd6
Cr-Commit-Position: refs/heads/master@{#409063}

[Mark Mentovai, 2016-08-01 19:06:20]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2016-08-01 19:06:21]

There should be no real behavior change here, although there are some hidden
changes: we’ll set a few process annotations in non-official-branding builds
that we previously didn’t set, and we’ll stop giving “none” to Crashpad as an
upload URL.

[Robert Sesek, 2016-08-01 20:06:07]

LGTM

[Mark Mentovai, 2016-08-01 20:23:16]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 20:23:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-08-01 20:27:07]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 20:27:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-08-01 20:28:16]

mark@chromium.org changed reviewers:
+ scottmg@chromium.org

[Mark Mentovai, 2016-08-01 20:28:16]

I was also able to remove --breakpad_uploads from tweak_info_plist.py.

+scottmg for OWNERS

[scottmg, 2016-08-01 20:38:34]

https://codereview.chromium.org/2204473002/diff/20001/build/mac/tweak_info_pl...
File build/mac/tweak_info_plist.py (right):

https://codereview.chromium.org/2204473002/diff/20001/build/mac/tweak_info_pl...
build/mac/tweak_info_plist.py:167: plist['BreakpadURL'] =
'https://clients2.google.com/cr/report'
BreakpadURL isn't used in crashpad_mac.mm any more? Do we need this at all?

[Mark Mentovai, 2016-08-01 20:39:23]

https://codereview.chromium.org/2204473002/diff/20001/build/mac/tweak_info_pl...
File build/mac/tweak_info_plist.py (right):

https://codereview.chromium.org/2204473002/diff/20001/build/mac/tweak_info_pl...
build/mac/tweak_info_plist.py:167: plist['BreakpadURL'] =
'https://clients2.google.com/cr/report'
scottmg (OOO until August) wrote:
> BreakpadURL isn't used in crashpad_mac.mm any more? Do we need this at all?

Content Shell and iOS still use Breakpad, so we need to hang on to this for them
at least. For now, anyway.

[scottmg, 2016-08-01 20:42:26]

On 2016/08/01 20:39:23, Mark Mentovai wrote:
>
https://codereview.chromium.org/2204473002/diff/20001/build/mac/tweak_info_pl...
> File build/mac/tweak_info_plist.py (right):
> 
>
https://codereview.chromium.org/2204473002/diff/20001/build/mac/tweak_info_pl...
> build/mac/tweak_info_plist.py:167: plist['BreakpadURL'] =
> 'https://clients2.google.com/cr/report'
> scottmg (OOO until August) wrote:
> > BreakpadURL isn't used in crashpad_mac.mm any more? Do we need this at all?
> 
> Content Shell and iOS still use Breakpad, so we need to hang on to this for
them
> at least. For now, anyway.

Oh right, didn't realize that script was used everywhere. lgtm.

[Mark Mentovai, 2016-08-01 20:58:53]

The CQ bit was unchecked by mark@chromium.org

[Mark Mentovai, 2016-08-01 20:58:56]

The CQ bit was checked by mark@chromium.org

[Mark Mentovai, 2016-08-01 20:58:57]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2204473002/#ps20001
(title: "Remove --breakpad_uploads from tweak_info_plist.py")

[commit-bot: I haz the power, 2016-08-01 20:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 21:38:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-01 21:47:46]

Description was changed from

==========
mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization

BUG=626811
==========

to

==========
mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization

BUG=626811

Committed: https://crrev.com/bd828670eaef26966373521fa23624d5b7b3ddd6
Cr-Commit-Position: refs/heads/master@{#409063}
==========

[commit-bot: I haz the power, 2016-08-01 21:47:47]

Patchset 2 (id:??) landed as
https://crrev.com/bd828670eaef26966373521fa23624d5b7b3ddd6
Cr-Commit-Position: refs/heads/master@{#409063}

[sdefresne, 2016-08-02 05:06:58]

On 2016/08/01 21:47:47, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/bd828670eaef26966373521fa23624d5b7b3ddd6
> Cr-Commit-Position: refs/heads/master@{#409063}

Hi,

I think this broke iOS.

First, it broke the build as iOS pass --breakpad_uploads when invoking
tweak_info_plist.py (sadly only in the downstream tree,
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/trunk-aut...).

Second, iOS still does not use crashpad AFAIK and so still use the BreakpadURL
Info.plist value for the initialisation of breakpad.

What is the correct fix for iOS? I think reverting the changes to
tweak_info_plist.py should be enough, but maybe we want to keep them for Mac. In
that case, should I make the code conditional on the target_os (know to the
script)?

Regards,

[Mark Mentovai, 2016-08-02 11:54:10]

I couldn’t fix your use of --breakpad_uploads because I didn’t even see it when
I looked on codesearch.chromium.org. You should just remove --breakpad_uploads
now. It’s unnecessary.

Everything else about tweak_info_plist.py should be OK for you. Notably, you can
still use it to enable Breakpad, and this will get you all of the same keys that
you used to get.

I didn’t think that you were using the Chromium Framework/Google Chrome
Framework target, at least not to enable Breakpad. And if you had been using
tweak_info_plist.py elsewhere to turn on --breakpad_uploads, it sounds like you
had another place to turn Breakpad on anyway.

[sdefresne, 2016-08-02 16:17:42]

On 2016/08/02 11:54:10, Mark Mentovai wrote:
> I couldn’t fix your use of --breakpad_uploads because I didn’t even see it
when
> I looked on http://codesearch.chromium.org. You should just remove
--breakpad_uploads
> now. It’s unnecessary.
> 
> Everything else about tweak_info_plist.py should be OK for you. Notably, you
can
> still use it to enable Breakpad, and this will get you all of the same keys
that
> you used to get.
> 
> I didn’t think that you were using the Chromium Framework/Google Chrome
> Framework target, at least not to enable Breakpad. And if you had been using
> tweak_info_plist.py elsewhere to turn on --breakpad_uploads, it sounds like
you
> had another place to turn Breakpad on anyway.

Ack, thank you.