Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/BUILD.gn

Issue 2204473002: mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove --breakpad_uploads from tweak_info_plist.py Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 75d02c1508bec378716395723b0b9d9113e20898..cb04370b3da98b02f7623e3c6a7a668eea49862e 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -936,13 +936,8 @@ if (is_win) {
tweak_info_plist("chrome_framework_plist") {
info_plist = "app/framework-Info.plist"
- _breakpad_uploads_arg = "0"
- if (enable_mac_crash_collection) {
- _breakpad_uploads_arg = "1"
- }
args = [
- "--breakpad=1",
- "--breakpad_uploads=$_breakpad_uploads_arg",
+ "--breakpad=0",
"--keystone=0",
"--scm=1",
"--branding",

Powered by Google App Engine
This is Rietveld 408576698