build/config/features.gni - Issue 2204473002: mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/features.gni

Issue 2204473002: mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove --breakpad_uploads from tweak_info_plist.py Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | build/mac/tweak_info_plist.py » ('j') | build/mac/tweak_info_plist.py » ('J')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # This file contains Chrome-feature-related build flags (see ui.gni for	5 # This file contains Chrome-feature-related build flags (see ui.gni for

6 # UI-related ones). These should theoretically be moved to the build files of	6 # UI-related ones). These should theoretically be moved to the build files of

7 # the features themselves.	7 # the features themselves.

8 #	8 #

9 # However, today we have many "bad" dependencies on some of these flags from,	9 # However, today we have many "bad" dependencies on some of these flags from,

10 # e.g. base, so they need to be global to match the GYP configuration. Also,	10 # e.g. base, so they need to be global to match the GYP configuration. Also,

(...skipping 159 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
170 # Use brlapi from brltty for braille display support.	170 # Use brlapi from brltty for braille display support.

171 use_brlapi = is_chromeos	171 use_brlapi = is_chromeos

172	172

173 # Enable WebVR support by default on Android	173 # Enable WebVR support by default on Android

174 # Still requires command line flag to access API	174 # Still requires command line flag to access API

175 enable_webvr = is_android	175 enable_webvr = is_android

176	176

177 enable_configuration_policy = !is_ios	177 enable_configuration_policy = !is_ios

178	178

179 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build	179 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build

180 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build

OLD	NEW