Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/BUILD.gn

Issue 2204473002: mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove --breakpad_uploads from tweak_info_plist.py Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 918 matching lines...) Expand 10 before | Expand all | Expand 10 after
929 "$output_path/KeystoneRegistration.framework", 929 "$output_path/KeystoneRegistration.framework",
930 ] 930 ]
931 } 931 }
932 } else { 932 } else {
933 group("keystone_registration_framework") { 933 group("keystone_registration_framework") {
934 } 934 }
935 } 935 }
936 936
937 tweak_info_plist("chrome_framework_plist") { 937 tweak_info_plist("chrome_framework_plist") {
938 info_plist = "app/framework-Info.plist" 938 info_plist = "app/framework-Info.plist"
939 _breakpad_uploads_arg = "0"
940 if (enable_mac_crash_collection) {
941 _breakpad_uploads_arg = "1"
942 }
943 args = [ 939 args = [
944 "--breakpad=1", 940 "--breakpad=0",
945 "--breakpad_uploads=$_breakpad_uploads_arg",
946 "--keystone=0", 941 "--keystone=0",
947 "--scm=1", 942 "--scm=1",
948 "--branding", 943 "--branding",
949 chrome_product_short_name, 944 chrome_product_short_name,
950 ] 945 ]
951 } 946 }
952 947
953 # On Mac, speed up the component build by not re-bundling the framework 948 # On Mac, speed up the component build by not re-bundling the framework
954 # every time it changes. Instead, place all the sources and their deps in 949 # every time it changes. Instead, place all the sources and their deps in
955 # a library that the bundled framework links (and re-exports). That way 950 # a library that the bundled framework links (and re-exports). That way
(...skipping 888 matching lines...) Expand 10 before | Expand all | Expand 10 after
1844 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1839 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1845 "//chrome/tools/build/linux/chrome-wrapper", 1840 "//chrome/tools/build/linux/chrome-wrapper",
1846 "//third_party/xdg-utils/scripts/xdg-mime", 1841 "//third_party/xdg-utils/scripts/xdg-mime",
1847 "//third_party/xdg-utils/scripts/xdg-settings", 1842 "//third_party/xdg-utils/scripts/xdg-settings",
1848 ] 1843 ]
1849 outputs = [ 1844 outputs = [
1850 "$root_out_dir/{{source_file_part}}", 1845 "$root_out_dir/{{source_file_part}}",
1851 ] 1846 ]
1852 } 1847 }
1853 } 1848 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698