Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3002)

Unified Diff: chrome/installer/mac/app/Downloader.h

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added use of temporary folders, removed semaphore from main installer code, adjusted some files' APIs, resolved remaining comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/app/Downloader.h
diff --git a/chrome/installer/mac/app/Downloader.h b/chrome/installer/mac/app/Downloader.h
index 72c63ad76d65f00a8fac913d2f987652c899f8b8..d41059e5652d6e2cf174163d91924a706e1c3112 100644
--- a/chrome/installer/mac/app/Downloader.h
+++ b/chrome/installer/mac/app/Downloader.h
@@ -9,9 +9,10 @@
@class Downloader;
@protocol DownloaderDelegate
-- (void)didDownloadData:(double)downloadProgressPercentage;
- (void)downloader:(Downloader*)download
- onDownloadSuccess:(NSURL*)diskImagePath;
+ didDownloadData:(double)downloadProgressPercentage;
Sidney San Martín 2016/08/13 12:37:18 `downloader:didDownloadData:` suggests that the se
Anna Zeng 2016/08/16 23:07:39 Done.
+- (void)downloader:(Downloader*)download
+ onDownloadSuccessWithDiskURL:(NSURL*)diskImagePath;
- (void)downloader:(Downloader*)download
onDownloadFailureWithError:(NSError*)error;
@end
@@ -20,12 +21,8 @@
@property(nonatomic, assign) id<DownloaderDelegate> delegate;
-// Takes an NSData with a response XML from Omaha and writes the latest
-// version of chrome to the user's download directory.
-- (void)downloadChromeImageToDownloadsDirectory:(NSURL*)chromeImageURL;
-
-// Returns a path to a user's home download folder.
-+ (NSString*)getChromeDownloadFilePath;
+// Downloads Chrome from the |chromeImageURL| to the local hard drive.
Sidney San Martín 2016/08/13 12:37:18 No "the".
Anna Zeng 2016/08/16 23:07:39 Done.
+- (void)downloadChromeImageFrom:(NSURL*)chromeImageURL;
@end

Powered by Google App Engine
This is Rietveld 408576698