chrome/installer/mac/app/Downloader.h - Issue 2203583002: Added unpacking step

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/Downloader.h

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added use of temporary folders, removed semaphore from main installer code, adjusted some files' APIs, resolved remaining comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/installer/mac/app/BUILD.gn ('K') | « chrome/installer/mac/app/BUILD.gn ('k') | chrome/installer/mac/app/Downloader.m » ('j') | chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_INSTALLER_MAC_APP_DOWNLOADER_H_	5 #ifndef CHROME_INSTALLER_MAC_APP_DOWNLOADER_H_

6 #define CHROME_INSTALLER_MAC_APP_DOWNLOADER_H_	6 #define CHROME_INSTALLER_MAC_APP_DOWNLOADER_H_

7	7

8 #import <Foundation/Foundation.h>	8 #import <Foundation/Foundation.h>

9	9

10 @class Downloader;	10 @class Downloader;

11 @protocol DownloaderDelegate	11 @protocol DownloaderDelegate

12 - (void)didDownloadData:(double)downloadProgressPercentage;

13 - (void)downloader:(Downloader*)download	12 - (void)downloader:(Downloader*)download

14 onDownloadSuccess:(NSURL*)diskImagePath;	13 didDownloadData:(double)downloadProgressPercentage;
	Sidney San Martín 2016/08/13 12:37:18 `downloader:didDownloadData:` suggests that the se `downloader:didDownloadData:` suggests that the second parameter is some data. I'd look for a clearer name — `downloader:progress:` would be fine, but there are other good ones too. Anna Zeng 2016/08/16 23:07:39 Done. Show quoted text On 2016/08/13 12:37:18, Sidney San Martín wrote: > `downloader:didDownloadData:` suggests that the second parameter is some data. > I'd look for a clearer name — `downloader:progress:` would be fine, but there > are other good ones too. Done.
	14 - (void)downloader:(Downloader*)download

	15 onDownloadSuccessWithDiskURL:(NSURL*)diskImagePath;

15 - (void)downloader:(Downloader*)download	16 - (void)downloader:(Downloader*)download

16 onDownloadFailureWithError:(NSError*)error;	17 onDownloadFailureWithError:(NSError*)error;

17 @end	18 @end

18	19

19 @interface Downloader : NSObject<NSURLSessionDownloadDelegate>	20 @interface Downloader : NSObject<NSURLSessionDownloadDelegate>

20	21

21 @property(nonatomic, assign) id<DownloaderDelegate> delegate;	22 @property(nonatomic, assign) id<DownloaderDelegate> delegate;

22	23

23 // Takes an NSData with a response XML from Omaha and writes the latest	24 // Downloads Chrome from the \|chromeImageURL\| to the local hard drive.
	Sidney San Martín 2016/08/13 12:37:18 No "the". No "the". Anna Zeng 2016/08/16 23:07:39 Done. Show quoted text On 2016/08/13 12:37:18, Sidney San Martín wrote: > No "the". Done.
24 // version of chrome to the user's download directory.	25 - (void)downloadChromeImageFrom:(NSURL*)chromeImageURL;

25 - (void)downloadChromeImageToDownloadsDirectory:(NSURL*)chromeImageURL;

26

27 // Returns a path to a user's home download folder.

28 + (NSString*)getChromeDownloadFilePath;

29	26

30 @end	27 @end

31	28

32 #endif // CHROME_INSTALLER_MAC_APP_DOWNLOADER_H_	29 #endif // CHROME_INSTALLER_MAC_APP_DOWNLOADER_H_

OLD	NEW