chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h - Issue 2203583002: Added unpacking step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added use of temporary folders, removed semaphore from main installer code, adjusted some files' APIs, resolved remaining comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/mac/app/Downloader.h ('K') | « chrome/installer/mac/app/MainDelegate.m ('k') | chrome/installer/mac/app/NSError+ChromeInstallerAdditions.h » ('j') | chrome/installer/mac/app/OmahaCommunication.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h

diff --git a/chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h b/chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h

index a74509af4c7f127c482a2bd7f2f1a68504711c7b..142a640585ddda04aac9e37ee3b0f3d742b12a56 100644

--- a/chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h

+++ b/chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h

@@ -9,6 +9,8 @@

typedef NSInteger NSModalResponse;

@interface NSAlert (ChromeInstallerAdditions)

+// Allows the caller to determine whether to determine the app's quit button was

+// pressed or not.

- (NSModalResponse)quitButton;

Elly Fong-Jones 2016/08/16 15:26:18 This isn't a button. Maybe (NSModalResponse)userRe

Anna Zeng 2016/08/16 23:07:39 Done.

@end