Chromium Code Reviews| Index: chrome/installer/mac/app/BUILD.gn |
| diff --git a/chrome/installer/mac/app/BUILD.gn b/chrome/installer/mac/app/BUILD.gn |
| index 31101a70e85d5fc8af89f440a7c4c291a45433c9..881fd001c5d645eee1fa95482b5a959d6ed8f625 100644 |
| --- a/chrome/installer/mac/app/BUILD.gn |
| +++ b/chrome/installer/mac/app/BUILD.gn |
| @@ -14,6 +14,7 @@ source_set("mac_installer_base") { |
| "OmahaXMLParser.m", |
| "OmahaXMLRequest.m", |
| "SystemInfo.m", |
| + "Unpacker.m", |
| ] |
| } |
| @@ -32,8 +33,8 @@ mac_app_bundle("mac_installer_app") { |
| ] |
| libs = [ |
| - "AppKit.framework", |
|
Elly Fong-Jones
2016/08/16 15:26:18
I'm surprised we no longer need these frameworks?
Anna Zeng
2016/08/16 23:07:39
The Cocoa Framework includes AppKit, CoreFoundatio
|
| - "CoreFoundation.framework", |
| + "Cocoa.framework", |
| + "DiskArbitration.framework", |
| ] |
| } |
| @@ -43,24 +44,11 @@ mac_xib_bundle_data("mac_installer_xibs") { |
| ] |
| } |
| -executable("mac_installer") { |
| - sources = [ |
| - "main.m", |
| - ] |
| - deps = [ |
| - ":mac_installer_base", |
| - ] |
| - |
| - libs = [ |
| - "AppKit.framework", |
| - "CoreFoundation.framework", |
| - ] |
| -} |
| - |
| test("mac_installer_unittests") { |
| sources = [ |
| "testing/OmahaXMLRequest_test.mm", |
| "testing/SystemInfo_test.mm", |
| + "testing/Unpacker_test.mm", |
| ] |
| deps = [ |
| ":mac_installer_base", |
| @@ -68,7 +56,10 @@ test("mac_installer_unittests") { |
| "//base/test:run_all_unittests", |
| "//testing/gtest:gtest", |
| ] |
| - libs = [ "Foundation.framework" ] |
| + libs = [ |
| + "Cocoa.framework", |
| + "DiskArbitration.framework", |
| + ] |
| data = [ |
| "testing/requestCheck.dtd", |
| "testing/requestSample.xml", |