Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9446)

Unified Diff: chrome/installer/mac/app/BUILD.gn

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added use of temporary folders, removed semaphore from main installer code, adjusted some files' APIs, resolved remaining comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/app/BUILD.gn
diff --git a/chrome/installer/mac/app/BUILD.gn b/chrome/installer/mac/app/BUILD.gn
index 31101a70e85d5fc8af89f440a7c4c291a45433c9..881fd001c5d645eee1fa95482b5a959d6ed8f625 100644
--- a/chrome/installer/mac/app/BUILD.gn
+++ b/chrome/installer/mac/app/BUILD.gn
@@ -14,6 +14,7 @@ source_set("mac_installer_base") {
"OmahaXMLParser.m",
"OmahaXMLRequest.m",
"SystemInfo.m",
+ "Unpacker.m",
]
}
@@ -32,8 +33,8 @@ mac_app_bundle("mac_installer_app") {
]
libs = [
- "AppKit.framework",
Elly Fong-Jones 2016/08/16 15:26:18 I'm surprised we no longer need these frameworks?
Anna Zeng 2016/08/16 23:07:39 The Cocoa Framework includes AppKit, CoreFoundatio
- "CoreFoundation.framework",
+ "Cocoa.framework",
+ "DiskArbitration.framework",
]
}
@@ -43,24 +44,11 @@ mac_xib_bundle_data("mac_installer_xibs") {
]
}
-executable("mac_installer") {
- sources = [
- "main.m",
- ]
- deps = [
- ":mac_installer_base",
- ]
-
- libs = [
- "AppKit.framework",
- "CoreFoundation.framework",
- ]
-}
-
test("mac_installer_unittests") {
sources = [
"testing/OmahaXMLRequest_test.mm",
"testing/SystemInfo_test.mm",
+ "testing/Unpacker_test.mm",
]
deps = [
":mac_installer_base",
@@ -68,7 +56,10 @@ test("mac_installer_unittests") {
"//base/test:run_all_unittests",
"//testing/gtest:gtest",
]
- libs = [ "Foundation.framework" ]
+ libs = [
+ "Cocoa.framework",
+ "DiskArbitration.framework",
+ ]
data = [
"testing/requestCheck.dtd",
"testing/requestSample.xml",

Powered by Google App Engine
This is Rietveld 408576698