Issue 2203003006: [som] Render alerts that don't have extensions.

Issue 2203003006: [som] Render alerts that don't have extensions. (Closed)

Created:
4 years, 4 months ago by seanmccullough1

Modified:
4 years, 4 months ago

Reviewers:
zhangtiff, martiniss

CC:
chromium-reviews, infra-reviews+infra_chromium.org

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Target Ref:
refs/heads/master

Project:
infra

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
	M	go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html	View	1	2 chunks	+24 lines, -1 line	0 comments	Download

Total messages: 9 (3 generated)

zhangtiff

On 2016/08/03 at 17:53:20, seanmccullough wrote: > Wait, should this be !!extension && !!extension.suspected_cls instead? ...

4 years, 4 months ago (2016-08-03 17:57:10 UTC) #3

seanmccullough1

On 2016/08/03 17:57:10, zhangtiff wrote: > On 2016/08/03 at 17:53:20, seanmccullough wrote: > > > ...

4 years, 4 months ago (2016-08-03 18:14:33 UTC) #4

zhangtiff

On 2016/08/03 at 18:14:33, seanmccullough wrote: > On 2016/08/03 17:57:10, zhangtiff wrote: > > On ...

4 years, 4 months ago (2016-08-03 18:33:56 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203003006/20001

4 years, 4 months ago (2016-08-03 18:34:26 UTC) #7

commit-bot: I haz the power

4 years, 4 months ago (2016-08-03 18:48:25 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/93c2512cd32375ba8859d9cae310a...