Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html

Issue 2203003006: [som] Render alerts that don't have extensions. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: add test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html
diff --git a/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html b/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html
index a17075207c86296cd05a1e469bf6e4c0d9af32d0..dea044b17a06a3062b05e07c904139477e4cb093 100644
--- a/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html
+++ b/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html
@@ -48,7 +48,7 @@
element._uberify = (url) => { return url; };
flush( () => {
let itm = element.$$("#test_results");
- assert.isDefined(itm);
+ assert.isNotNull(itm);
assert.equal(
itm.children[0].href,
"https://test-results.appspot.com/dashboards/flakiness_dashboard" +
@@ -57,6 +57,29 @@
});
});
+
+ test('renders suspect CLs', function(done) {
+ element.extension = {
+ reasons: [{
+ "step": "wekbit_tests",
+ "test_names": [
+ "best_test",
+ ],
+ }],
+ suspected_cls: [
+ {revision: '1234'},
+ ],
+ };
+ element._uberify = (url) => { return url; };
+ flush( () => {
+ let itm = element.$$("#findit-results");
+ assert.isNotNull(itm);
+ assert.equal(
+ itm.children[1].href, "https://crrev.com/1234");
+ done();
+ });
+
+ });
});
})();
</script>
« no previous file with comments | « go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698