Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html

Issue 2203003006: [som] Render alerts that don't have extensions. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: add test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="/bower_components/polymer/polymer.html"> 1 <link rel="import" href="/bower_components/polymer/polymer.html">
2 <link rel="import" href="/bower_components/iron-ajax/iron-ajax.html"> 2 <link rel="import" href="/bower_components/iron-ajax/iron-ajax.html">
3 <link rel="import" href="/bower_components/iron-collapse/iron-collapse.html"> 3 <link rel="import" href="/bower_components/iron-collapse/iron-collapse.html">
4 <link rel="import" href="/bower_components/iron-flex-layout/classes/iron-flex-la yout.html"> 4 <link rel="import" href="/bower_components/iron-flex-layout/classes/iron-flex-la yout.html">
5 <link rel="import" href="/bower_components/iron-icons/hardware-icons.html"> 5 <link rel="import" href="/bower_components/iron-icons/hardware-icons.html">
6 <link rel="import" href="/bower_components/iron-icons/iron-icons.html"> 6 <link rel="import" href="/bower_components/iron-icons/iron-icons.html">
7 <link rel="import" href="/bower_components/iron-page-url/iron-page-url.html"> 7 <link rel="import" href="/bower_components/iron-page-url/iron-page-url.html">
8 <link rel="import" href="/bower_components/paper-button/paper-button.html"> 8 <link rel="import" href="/bower_components/paper-button/paper-button.html">
9 <link rel="import" href="/bower_components/paper-card/paper-card.html"> 9 <link rel="import" href="/bower_components/paper-card/paper-card.html">
10 <link rel="import" href="/bower_components/paper-drawer-panel/paper-drawer-panel .html"> 10 <link rel="import" href="/bower_components/paper-drawer-panel/paper-drawer-panel .html">
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 if (this._failureCount(builder) > 1) { 154 if (this._failureCount(builder) > 1) {
155 classes.push('multiple-failures'); 155 classes.push('multiple-failures');
156 } 156 }
157 if (this.type == 'infra-failure') { 157 if (this.type == 'infra-failure') {
158 classes.push('infra-failure'); 158 classes.push('infra-failure');
159 } 159 }
160 return classes.join(' '); 160 return classes.join(' ');
161 }, 161 },
162 162
163 _haveSuspectCLs: function(extension) { 163 _haveSuspectCLs: function(extension) {
164 return !!extension.suspected_cls; 164 return extension && extension.suspected_cls;
165 }, 165 },
166 166
167 _linkForTest: function(reason, testName) { 167 _linkForTest: function(reason, testName) {
168 return 'https://test-results.appspot.com/dashboards/flakiness_dashboard. html#' + 168 return 'https://test-results.appspot.com/dashboards/flakiness_dashboard. html#' +
169 "tests=" + encodeURIComponent(testName) + 169 "tests=" + encodeURIComponent(testName) +
170 "&testType=" + encodeURIComponent(reason.step) 170 "&testType=" + encodeURIComponent(reason.step)
171 ; 171 ;
172 }, 172 },
173 173
174 _linkForCL: function(cl) { 174 _linkForCL: function(cl) {
175 return 'https://crrev.com/' + cl.revision; 175 return 'https://crrev.com/' + cl.revision;
176 }, 176 },
177 177
178 _showRegressionRange: function(range) { 178 _showRegressionRange: function(range) {
179 return range.positions && range.positions.length > 0 && 179 return range.positions && range.positions.length > 0 &&
180 range.repo != 'v8'; 180 range.repo != 'v8';
181 }, 181 },
182 182
183 _textForCL: function(cl) { 183 _textForCL: function(cl) {
184 return '(details)'; 184 return '(details)';
185 }, 185 },
186 }); 186 });
187 })(); 187 })();
188 </script> 188 </script>
189 </dom-module> 189 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698