go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html - Issue 2203003006: [som] Render alerts that don't have extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html

Issue 2203003006: [som] Render alerts that don't have extensions. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: add test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html

diff --git a/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html b/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html

index 910e78dffaa7835537157f26651a33141075339e..c005d5612e61ef471aeec248bf3dc87faaae7a7a 100644

--- a/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html

+++ b/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html

@@ -161,7 +161,7 @@

_haveSuspectCLs: function(extension) {

- return !!extension.suspected_cls;

+ return extension && extension.suspected_cls;

_linkForTest: function(reason, testName) {

« no previous file with comments | « no previous file | go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html » ('j') | no next file with comments »