Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2202023005: Mojo C++ bindings: inline pointer encoding/decoding/validating functions. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), Dirk Pranke, Fady Samuel, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@85_inline_data_view
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: inline pointer encoding/decoding/validating functions. These functions are very small and frequently called. Inlining them improves serialization/deserialization by 5~10%. BUG=624459 Committed: https://crrev.com/3a929002a82792cb1cfd9a0eb501fa2b84a1707d Cr-Commit-Position: refs/heads/master@{#409214}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -64 lines) Patch
M mojo/mojo_public.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_internal.h View 2 chunks +19 lines, -4 lines 0 comments Download
D mojo/public/cpp/bindings/lib/bindings_internal.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_util.h View 1 chunk +9 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/validation_util.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yzshen1
Average numbers from three runs of cc_perftests: Deserialization: ======================================================= ' StructTraits deserialization: num runs in ...
4 years, 4 months ago (2016-08-02 00:16:33 UTC) #3
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 4 months ago (2016-08-02 00:17:27 UTC) #5
Ken Rockot(use gerrit already)
lgtm
4 years, 4 months ago (2016-08-02 00:57:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202023005/20001
4 years, 4 months ago (2016-08-02 15:49:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 17:13:14 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 17:16:27 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a929002a82792cb1cfd9a0eb501fa2b84a1707d
Cr-Commit-Position: refs/heads/master@{#409214}

Powered by Google App Engine
This is Rietveld 408576698