Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2203953003: [not for commit (yet)] inline more things but doesn't seem to improve perf

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@85_3_inline_validation_context
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[not for commit (yet)] inline more things but doesn't seem to improve perf BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -167 lines) Patch
M mojo/public/cpp/bindings/lib/validation_util.h View 3 chunks +128 lines, -26 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_util.cc View 2 chunks +0 lines, -141 lines 0 comments Download

Depends on Patchset:

Issue 2202423002 Patch 40001

Messages

Total messages: 1 (0 generated)
yzshen1
4 years, 4 months ago (2016-08-02 21:00:48 UTC) #1 
------------------------------
' ParamTraits deserialization: min_frame_deserialization_time:
DelegatedFrame_ManyQuads_100000_100000': base: 25482.0 new: 25128.2 imprv:
1.0140797987917956
' ParamTraits deserialization: min_frame_deserialization_time:
DelegatedFrame_ManyQuads_1_100000': base: 12194.566666666666 new:
10966.233333333335 imprv: 1.1120105049743605
' ParamTraits deserialization: min_frame_deserialization_time:
DelegatedFrame_ManyQuads_1_4000': base: 471.76666666666665 new:
449.06666666666666 imprv: 1.0505492874109263
' ParamTraits deserialization: min_frame_deserialization_time:
DelegatedFrame_ManyQuads_4000_4000': base: 929.3666666666667 new:
884.4666666666666 imprv: 1.050765056154368
' ParamTraits deserialization: min_frame_deserialization_time:
DelegatedFrame_ManyRenderPasses_10000_100': base: 27186.733333333334 new:
26182.36666666667 imprv: 1.0383604232365038
' ParamTraits deserialization: min_frame_deserialization_time:
DelegatedFrame_ManyRenderPasses_10_500': base: 1196.7333333333333 new:
1137.8333333333333 imprv: 1.0517650505346419
' ParamTraits deserialization: min_frame_deserialization_time:
DelegatedFrame_ManyRenderPasses_5_100': base: 79.23333333333333 new:
77.83333333333333 imprv: 1.0179871520342614
' ParamTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_100000_100000': base: 75.66666666666667 new:
77.66666666666667 imprv: 1.026431718061674
' ParamTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_100000': base: 156.0 new: 176.0 imprv:
1.1282051282051282
' ParamTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_4000': base: 3946.0 new: 4205.666666666667 imprv:
1.065805034634229
' ParamTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_4000_4000': base: 2062.3333333333335 new:
2156.6666666666665 imprv: 1.0457410699854532
' ParamTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10000_100': base: 70.66666666666667 new:
72.33333333333333 imprv: 1.0235849056603772
' ParamTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10_500': base: 1590.0 new: 1695.0 imprv:
1.0660377358490567
' ParamTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_5_100': base: 23424.666666666668 new:
24552.666666666668 imprv: 1.0481543671912799
------------------------------
' ParamTraits serialization: min_frame_serialization_time:
DelegatedFrame_ManyQuads_100000_100000': base: 20447.633333333335 new:
20374.96666666667 imprv: 1.0035664680024015
' ParamTraits serialization: min_frame_serialization_time:
DelegatedFrame_ManyQuads_1_100000': base: 8605.866666666667 new:
8513.933333333332 imprv: 1.0107979860464025
' ParamTraits serialization: min_frame_serialization_time:
DelegatedFrame_ManyQuads_1_4000': base: 355.90000000000003 new:
354.1333333333334 imprv: 1.0049887048192772
' ParamTraits serialization: min_frame_serialization_time:
DelegatedFrame_ManyQuads_4000_4000': base: 836.5666666666666 new:
797.4666666666667 imprv: 1.04903026249791
' ParamTraits serialization: min_frame_serialization_time:
DelegatedFrame_ManyRenderPasses_10000_100': base: 20791.433333333334 new:
20476.333333333332 imprv: 1.015388497289554
' ParamTraits serialization: min_frame_serialization_time:
DelegatedFrame_ManyRenderPasses_10_500': base: 1046.6000000000001 new: 1005.4
imprv: 1.0409787149393277
' ParamTraits serialization: min_frame_serialization_time:
DelegatedFrame_ManyRenderPasses_5_100': base: 106.36666666666667 new: 101.3
imprv: 1.05001645278052
' ParamTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_100000_100000': base: 94.33333333333333 new: 94.0
imprv: 0.9964664310954064
' ParamTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_100000': base: 222.66666666666666 new:
224.33333333333334 imprv: 1.00748502994012
' ParamTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_4000': base: 5325.666666666667 new: 5255.666666666667
imprv: 0.9868561056518745
' ParamTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_4000_4000': base: 2293.0 new: 2442.0 imprv:
1.0649803750545137
' ParamTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10000_100': base: 93.0 new: 94.66666666666667
imprv: 1.017921146953405
' ParamTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10_500': base: 1817.6666666666667 new:
1915.6666666666667 imprv: 1.0539152759948651
' ParamTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_5_100': base: 17770.666666666668 new:
18619.333333333332 imprv: 1.0477566026410563
------------------------------
' StructTraits deserialization min_frame_deserialization_time:
DelegatedFrame_ManyQuads_100000_100000': base: 41186.46666666667 new: 38804.4
imprv: 1.061386509433638
' StructTraits deserialization min_frame_deserialization_time:
DelegatedFrame_ManyQuads_1_100000': base: 17260.833333333332 new:
17541.033333333333 imprv: 0.9840260265928841
' StructTraits deserialization min_frame_deserialization_time:
DelegatedFrame_ManyQuads_1_4000': base: 590.4333333333334 new: 579.3666666666667
imprv: 1.019101317530637
' StructTraits deserialization min_frame_deserialization_time:
DelegatedFrame_ManyQuads_4000_4000': base: 1308.8666666666666 new:
1268.6666666666667 imprv: 1.031686810299527
' StructTraits deserialization min_frame_deserialization_time:
DelegatedFrame_ManyRenderPasses_10000_100': base: 42908.166666666664 new:
45072.76666666666 imprv: 0.9519754352776215
' StructTraits deserialization min_frame_deserialization_time:
DelegatedFrame_ManyRenderPasses_10_500': base: 1527.2666666666667 new:
1457.6000000000001 imprv: 1.0477954628613244
' StructTraits deserialization min_frame_deserialization_time:
DelegatedFrame_ManyRenderPasses_5_100': base: 133.63333333333335 new:
126.53333333333332 imprv: 1.0561116965226558
------------------------------
' StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_100000_100000': base: 46.666666666666664 new:
49.333333333333336 imprv: 1.0571428571428572
' StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_100000': base: 110.0 new: 110.0 imprv: 1.0
' StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_4000': base: 3315.3333333333335 new:
3294.6666666666665 imprv: 0.9937663382264226
' StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_4000_4000': base: 1443.0 new: 1531.6666666666667 imprv:
1.0614460614460615
' StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10000_100': base: 42.666666666666664 new: 43.0
imprv: 1.0078125
' StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10_500': base: 1250.0 new: 1302.6666666666667
imprv: 1.0421333333333334
' StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_5_100': base: 14059.333333333334 new:
15190.333333333334 imprv: 1.0804447816397174
------------------------------
' StructTraits serialization min_frame_serialization_time:
DelegatedFrame_ManyQuads_100000_100000': base: 31149.966666666664 new:
28197.966666666664 imprv: 1.1046883995181687
' StructTraits serialization min_frame_serialization_time:
DelegatedFrame_ManyQuads_1_100000': base: 14263.466666666667 new:
14211.199999999999 imprv: 1.003677850334009
' StructTraits serialization min_frame_serialization_time:
DelegatedFrame_ManyQuads_1_4000': base: 519.4666666666666 new: 513.9 imprv:
1.010832198222741
' StructTraits serialization min_frame_serialization_time:
DelegatedFrame_ManyQuads_4000_4000': base: 1057.0666666666666 new:
1041.6000000000001 imprv: 1.014848950332821
' StructTraits serialization min_frame_serialization_time:
DelegatedFrame_ManyRenderPasses_10000_100': base: 30650.399999999998 new:
29466.36666666667 imprv: 1.0401825357950476
' StructTraits serialization min_frame_serialization_time:
DelegatedFrame_ManyRenderPasses_10_500': base: 1387.2 new: 1304.3333333333333
imprv: 1.0635318170201893
' StructTraits serialization min_frame_serialization_time:
DelegatedFrame_ManyRenderPasses_5_100': base: 129.70000000000002 new:
130.5666666666667 imprv: 0.9933622670411029
------------------------------
' StructTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_100000_100000': base: 62.333333333333336 new:
68.33333333333333 imprv: 1.0962566844919786
' StructTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_100000': base: 133.33333333333334 new:
137.66666666666666 imprv: 1.0324999999999998
' StructTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_4000': base: 3780.0 new: 3775.6666666666665 imprv:
0.9988536155202822
' StructTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_4000_4000': base: 1816.6666666666667 new: 1859.0 imprv:
1.023302752293578
' StructTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10000_100': base: 62.666666666666664 new:
66.33333333333333 imprv: 1.0585106382978724
' StructTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10_500': base: 1355.6666666666667 new: 1480.0
imprv: 1.0917137939513155
' StructTraits serialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_5_100': base: 14138.333333333334 new:
14363.333333333334 imprv: 1.015914181303784

Powered by Google App Engine
This is Rietveld 408576698