Revert of Disable broken iOS10 password manager tests.

components/password_manager/core/browser/login_database_ios_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/login_database.h"
 
 #include <Security/Security.h>
 #include <stddef.h>
 
 #include "base/files/scoped_temp_dir.h"
@@ skipping 64 matching lines @@
   if (status == errSecItemNotFound)
     return 0;
 
   EXPECT_EQ(errSecSuccess, status);
   size_t size = CFArrayGetCount((CFArrayRef)result);
   CFRelease(result);
   return size;
 }
 
 TEST_F(LoginDatabaseIOSTest, KeychainStorage) {
-#if TARGET_IPHONE_SIMULATOR
-  // TODO(crbug.com/619982): Broken by iOS10.
-  if (base::ios::IsRunningOnIOS10OrLater()) {
-    return;
-  }
-#endif
-
   base::string16 test_passwords[] = {
       base::ASCIIToUTF16("foo"), base::ASCIIToUTF16("bar"),
       base::WideToUTF16(L"\u043F\u0430\u0440\u043E\u043B\u044C"),
       base::string16(),
   };
 
   for (unsigned int i = 0; i < arraysize(test_passwords); i++) {
     std::string encrypted;
     EXPECT_EQ(LoginDatabase::ENCRYPTION_RESULT_SUCCESS,
               login_db_->EncryptedString(test_passwords[i], &encrypted));
     base::string16 decrypted;
     EXPECT_EQ(LoginDatabase::ENCRYPTION_RESULT_SUCCESS,
               login_db_->DecryptedString(encrypted, &decrypted));
     EXPECT_STREQ(UTF16ToUTF8(test_passwords[i]).c_str(),
                  UTF16ToUTF8(decrypted).c_str());
   }
 }
 
 TEST_F(LoginDatabaseIOSTest, UpdateLogin) {
-#if TARGET_IPHONE_SIMULATOR
-  // TODO(crbug.com/619982): Broken by iOS10.
-  if (base::ios::IsRunningOnIOS10OrLater()) {
-    return;
-  }
-#endif
-
   PasswordForm form;
   form.origin = GURL("http://0.com");
   form.signon_realm = "http://www.example.com";
   form.action = GURL("http://www.example.com/action");
   form.password_element = base::ASCIIToUTF16("pwd");
   form.password_value = base::ASCIIToUTF16("example");
 
   ignore_result(login_db_->AddLogin(form));
 
   form.password_value = base::ASCIIToUTF16("secret");
 
   password_manager::PasswordStoreChangeList changes =
       login_db_->UpdateLogin(form);
   ASSERT_EQ(1u, changes.size());
 
   ScopedVector<PasswordForm> forms;
   EXPECT_TRUE(login_db_->GetLogins(PasswordStore::FormDigest(form), &forms));
 
   ASSERT_EQ(1U, forms.size());
   EXPECT_STREQ("secret", UTF16ToUTF8(forms[0]->password_value).c_str());
   ASSERT_EQ(1U, GetKeychainSize());
 }
 
 TEST_F(LoginDatabaseIOSTest, RemoveLogin) {
-#if TARGET_IPHONE_SIMULATOR
-  // TODO(crbug.com/619982): Broken by iOS10.
-  if (base::ios::IsRunningOnIOS10OrLater()) {
-    return;
-  }
-#endif
-
   PasswordForm form;
   form.signon_realm = "www.example.com";
   form.action = GURL("www.example.com/action");
   form.password_element = base::ASCIIToUTF16("pwd");
   form.password_value = base::ASCIIToUTF16("example");
 
   ignore_result(login_db_->AddLogin(form));
 
   ignore_result(login_db_->RemoveLogin(form));
 
   ScopedVector<PasswordForm> forms;
   EXPECT_TRUE(login_db_->GetLogins(PasswordStore::FormDigest(form), &forms));
 
   ASSERT_EQ(0U, forms.size());
   ASSERT_EQ(0U, GetKeychainSize());
 }
 
 TEST_F(LoginDatabaseIOSTest, RemoveLoginsCreatedBetween) {
-#if TARGET_IPHONE_SIMULATOR
-  // TODO(crbug.com/619982): Broken by iOS10.
-  if (base::ios::IsRunningOnIOS10OrLater()) {
-    return;
-  }
-#endif
-
   PasswordForm forms[3];
   forms[0].origin = GURL("http://0.com");
   forms[0].signon_realm = "http://www.example.com";
   forms[0].username_element = base::ASCIIToUTF16("login0");
   forms[0].date_created = base::Time::FromDoubleT(100);
   forms[0].password_value = base::ASCIIToUTF16("pass0");
 
   forms[1].origin = GURL("http://1.com");
   forms[1].signon_realm = "http://www.example.com";
   forms[1].username_element = base::ASCIIToUTF16("login1");
@@ skipping 21 matching lines @@
   ASSERT_EQ(2U, logins.size());
   ASSERT_EQ(2U, GetKeychainSize());
 
   EXPECT_STREQ("login0", UTF16ToUTF8(logins[0]->username_element).c_str());
   EXPECT_STREQ("pass0", UTF16ToUTF8(logins[0]->password_value).c_str());
   EXPECT_STREQ("login2", UTF16ToUTF8(logins[1]->username_element).c_str());
   EXPECT_STREQ("pass2", UTF16ToUTF8(logins[1]->password_value).c_str());
 }
 
 }  // namespace password_manager