Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2200263005: Remove ActiveDOMCallback::isScriptControllerTerminating (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 4 months ago
Reviewers:
peria, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ActiveDOMCallback::isScriptControllerTerminating We stopped returning an empty handle from toV8(). Now we can remove the IsEmpty() check for the handle returned by toV8(). Also this CL removes ActiveDOMCallback::isScriptControllerTerminating. The check shouldn't have been necessary because if the ScriptController is terminating, ScriptState::contextIsValid() returns false and we won't reach the check in the first place. BUG=625512 Committed: https://crrev.com/dffcde2825d2d8bbf7d0e19e978ba95a169c147a Cr-Commit-Position: refs/heads/master@{#412486}

Patch Set 1 #

Messages

Total messages: 10 (4 generated)
haraken
PTAL This CL depends on https://codereview.chromium.org/2209593002/.
4 years, 4 months ago (2016-08-03 09:18:07 UTC) #2
peria
lgtm
4 years, 4 months ago (2016-08-03 09:23:49 UTC) #4
Yuki
lgtm
4 years, 4 months ago (2016-08-03 09:25:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200263005/1
4 years, 4 months ago (2016-08-17 06:39:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 10:06:33 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 10:08:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dffcde2825d2d8bbf7d0e19e978ba95a169c147a
Cr-Commit-Position: refs/heads/master@{#412486}

Powered by Google App Engine
This is Rietveld 408576698