third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.cpp - Issue 2200263005: Remove ActiveDOMCallback::isScriptControllerTerminating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.cpp

Issue 2200263005: Remove ActiveDOMCallback::isScriptControllerTerminating (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.cpp

index de5d778f6d14f8461d962e7d49b8abd7f22c13f4..f1db90243f6c90efc9bf141981e6f1eec311cdd5 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.cpp

@@ -39,12 +39,6 @@ void V8IDBObserverCallback::handleChanges(IDBObserverChanges& changes, IDBObserv

if (m_callback.isEmpty())

return;

v8::Local<v8::Value> observerHandle = toV8(&observer, m_scriptState->context()->Global(), m_scriptState->isolate());

- if (observerHandle.IsEmpty()) {

- if (!isScriptControllerTerminating())

- CRASH();

- return;

- }

if (!observerHandle->IsObject())

return;