third_party/WebKit/Source/bindings/templates/callback_interface.cpp - Issue 2200263005: Remove ActiveDOMCallback::isScriptControllerTerminating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_interface.cpp

Issue 2200263005: Remove ActiveDOMCallback::isScriptControllerTerminating (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_interface.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/callback_interface.cpp b/third_party/WebKit/Source/bindings/templates/callback_interface.cpp

index e3bb988172543fc179473e33db3db3c498cf4fe6..eea852f8457fa2ee1717d946c865e3e3f634e25d 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_interface.cpp

+++ b/third_party/WebKit/Source/bindings/templates/callback_interface.cpp

@@ -38,19 +38,9 @@ DEFINE_TRACE({{v8_class}})

ScriptState::Scope scope(m_scriptState.get());

{% if method.call_with_this_handle %}

v8::Local<v8::Value> thisHandle = thisValue.v8Value();

- if (thisHandle.IsEmpty()) {

- if (!isScriptControllerTerminating())

- CRASH();

- {{return_default}};

- }

{% endif %}

{% for argument in method.arguments %}

v8::Local<v8::Value> {{argument.handle}} = {{argument.cpp_value_to_v8_value}};

- if ({{argument.handle}}.IsEmpty()) {

- if (!isScriptControllerTerminating())

- CRASH();

- {{return_default}};

- }

{% endfor %}

{% if method.arguments %}

v8::Local<v8::Value> argv[] = { {{method.arguments | join(', ', 'handle')}} };