Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp

Issue 2200263005: Remove ActiveDOMCallback::isScriptControllerTerminating (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/templates/callback_interface.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
index 34a713182eb5a6c0c7589f628f079dddfbea2ef6..9b412784fb3554202b91727cd7c54a62dc1255b5 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
@@ -74,11 +74,6 @@ void V8TestCallbackInterface::voidMethodBooleanArg(bool boolArg)
ScriptState::Scope scope(m_scriptState.get());
v8::Local<v8::Value> boolArgHandle = v8Boolean(boolArg, m_scriptState->isolate());
- if (boolArgHandle.IsEmpty()) {
- if (!isScriptControllerTerminating())
- CRASH();
- return;
- }
v8::Local<v8::Value> argv[] = { boolArgHandle };
V8ScriptRunner::callFunction(m_callback.newLocal(m_scriptState->isolate()), m_scriptState->getExecutionContext(), v8::Undefined(m_scriptState->isolate()), 1, argv, m_scriptState->isolate());
@@ -94,11 +89,6 @@ void V8TestCallbackInterface::voidMethodSequenceArg(const HeapVector<Member<Test
ScriptState::Scope scope(m_scriptState.get());
v8::Local<v8::Value> sequenceArgHandle = toV8(sequenceArg, m_scriptState->context()->Global(), m_scriptState->isolate());
- if (sequenceArgHandle.IsEmpty()) {
- if (!isScriptControllerTerminating())
- CRASH();
- return;
- }
v8::Local<v8::Value> argv[] = { sequenceArgHandle };
V8ScriptRunner::callFunction(m_callback.newLocal(m_scriptState->isolate()), m_scriptState->getExecutionContext(), v8::Undefined(m_scriptState->isolate()), 1, argv, m_scriptState->isolate());
@@ -114,11 +104,6 @@ void V8TestCallbackInterface::voidMethodFloatArg(float floatArg)
ScriptState::Scope scope(m_scriptState.get());
v8::Local<v8::Value> floatArgHandle = v8::Number::New(m_scriptState->isolate(), floatArg);
- if (floatArgHandle.IsEmpty()) {
- if (!isScriptControllerTerminating())
- CRASH();
- return;
- }
v8::Local<v8::Value> argv[] = { floatArgHandle };
V8ScriptRunner::callFunction(m_callback.newLocal(m_scriptState->isolate()), m_scriptState->getExecutionContext(), v8::Undefined(m_scriptState->isolate()), 1, argv, m_scriptState->isolate());
@@ -134,11 +119,6 @@ void V8TestCallbackInterface::voidMethodTestInterfaceEmptyArg(TestInterfaceEmpty
ScriptState::Scope scope(m_scriptState.get());
v8::Local<v8::Value> testInterfaceEmptyArgHandle = toV8(testInterfaceEmptyArg, m_scriptState->context()->Global(), m_scriptState->isolate());
- if (testInterfaceEmptyArgHandle.IsEmpty()) {
- if (!isScriptControllerTerminating())
- CRASH();
- return;
- }
v8::Local<v8::Value> argv[] = { testInterfaceEmptyArgHandle };
V8ScriptRunner::callFunction(m_callback.newLocal(m_scriptState->isolate()), m_scriptState->getExecutionContext(), v8::Undefined(m_scriptState->isolate()), 1, argv, m_scriptState->isolate());
@@ -154,17 +134,7 @@ void V8TestCallbackInterface::voidMethodTestInterfaceEmptyStringArg(TestInterfac
ScriptState::Scope scope(m_scriptState.get());
v8::Local<v8::Value> testInterfaceEmptyArgHandle = toV8(testInterfaceEmptyArg, m_scriptState->context()->Global(), m_scriptState->isolate());
- if (testInterfaceEmptyArgHandle.IsEmpty()) {
- if (!isScriptControllerTerminating())
- CRASH();
- return;
- }
v8::Local<v8::Value> stringArgHandle = v8String(m_scriptState->isolate(), stringArg);
- if (stringArgHandle.IsEmpty()) {
- if (!isScriptControllerTerminating())
- CRASH();
- return;
- }
v8::Local<v8::Value> argv[] = { testInterfaceEmptyArgHandle, stringArgHandle };
V8ScriptRunner::callFunction(m_callback.newLocal(m_scriptState->isolate()), m_scriptState->getExecutionContext(), v8::Undefined(m_scriptState->isolate()), 2, argv, m_scriptState->isolate());
@@ -180,17 +150,7 @@ void V8TestCallbackInterface::callbackWithThisValueVoidMethodStringArg(ScriptVal
ScriptState::Scope scope(m_scriptState.get());
v8::Local<v8::Value> thisHandle = thisValue.v8Value();
- if (thisHandle.IsEmpty()) {
- if (!isScriptControllerTerminating())
- CRASH();
- return;
- }
v8::Local<v8::Value> stringArgHandle = v8String(m_scriptState->isolate(), stringArg);
- if (stringArgHandle.IsEmpty()) {
- if (!isScriptControllerTerminating())
- CRASH();
- return;
- }
v8::Local<v8::Value> argv[] = { stringArgHandle };
V8ScriptRunner::callFunction(m_callback.newLocal(m_scriptState->isolate()), m_scriptState->getExecutionContext(), thisHandle, 1, argv, m_scriptState->isolate());
« no previous file with comments | « third_party/WebKit/Source/bindings/templates/callback_interface.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698