Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2199273002: Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN (Closed)

Created:
4 years, 4 months ago by borenet2
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio, borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN BUG=skia:5597 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199273002 Committed: https://skia.googlesource.com/skia/+/b6aafe66a0f59839bcacdac0b9037136e48f85e9

Patch Set 1 #

Patch Set 2 : Fix platforms for GN #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -40 lines) Patch
M infra/bots/recipe_modules/skia/api.py View 1 chunk +3 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_RecreateSKPs.py View 1 chunk +7 lines, -6 lines 0 comments Download
M infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json View 2 chunks +6 lines, -17 lines 0 comments Download
M infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json View 2 chunks +6 lines, -17 lines 0 comments Download
M tools/build_command_buffer.py View 1 1 chunk +19 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (5 generated)
borenet
CommandBuffer trybot got past the compile. I couldn't test RecreateSKPs locally...
4 years, 4 months ago (2016-08-02 13:28:33 UTC) #3
rmistry
LGTM On 2016/08/02 13:28:33, borenet wrote: > CommandBuffer trybot got past the compile. I couldn't ...
4 years, 4 months ago (2016-08-02 13:35:39 UTC) #4
borenet
On 2016/08/02 13:35:39, rmistry wrote: > LGTM > > > On 2016/08/02 13:28:33, borenet wrote: ...
4 years, 4 months ago (2016-08-02 13:37:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199273002/20001
4 years, 4 months ago (2016-08-02 13:37:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/b6aafe66a0f59839bcacdac0b9037136e48f85e9
4 years, 4 months ago (2016-08-02 14:02:56 UTC) #9
jcgregorio
https://codereview.chromium.org/2199273002/diff/20001/tools/build_command_buffer.py File tools/build_command_buffer.py (right): https://codereview.chromium.org/2199273002/diff/20001/tools/build_command_buffer.py#newcode143 tools/build_command_buffer.py:143: gn = os.path.join(chrome_src_dir, 'buildtools', platform, 'gn') Wouldn't that be ...
4 years, 4 months ago (2016-08-02 14:47:49 UTC) #11
borenet
4 years, 4 months ago (2016-08-02 15:11:56 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/2199273002/diff/20001/tools/build_command_buf...
File tools/build_command_buffer.py (right):

https://codereview.chromium.org/2199273002/diff/20001/tools/build_command_buf...
tools/build_command_buffer.py:143: gn = os.path.join(chrome_src_dir,
'buildtools', platform, 'gn')
On 2016/08/02 14:47:49, jcgregorio wrote:
> Wouldn't that be gn.exe on Windows?

Good catch. Fixed in https://codereview.chromium.org/2207563002

Powered by Google App Engine
This is Rietveld 408576698