Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: infra/bots/recipes/swarm_RecreateSKPs.py

Issue 2199273002: Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix platforms for GN Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipes/swarm_RecreateSKPs.py
diff --git a/infra/bots/recipes/swarm_RecreateSKPs.py b/infra/bots/recipes/swarm_RecreateSKPs.py
index 6863b020b753ee453b08ee1dd59a4caf93e488f8..49f9c11678046d64aecef06e8724ab3448e4fb0a 100644
--- a/infra/bots/recipes/swarm_RecreateSKPs.py
+++ b/infra/bots/recipes/swarm_RecreateSKPs.py
@@ -92,20 +92,21 @@ if os.path.isfile(backup_file):
def RunSteps(api):
# Check out Chrome.
api.skia.setup()
- api.gclient.runhooks(
- env={'CPPFLAGS': '-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1'})
src_dir = api.skia.checkout_root.join('src')
+ out_dir = src_dir.join('out', 'Release')
- # Call build/gyp_chromium
- api.step('gyp_chromium',
- ['build/gyp_chromium'],
+ # Call GN.
+ platform = 'linux64' # This bot only runs on linux; don't bother checking.
+ gn = src_dir.join('buildtools', platform, 'gn')
+ api.step('GN',
+ [gn, 'gen', out_dir],
env={'CPPFLAGS': '-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1',
'GYP_GENERATORS': 'ninja'},
cwd=src_dir)
# Build Chrome.
api.step('Build Chrome',
- ['ninja', '-C', 'out/Release', 'chrome'],
+ ['ninja', '-C', out_dir, 'chrome'],
cwd=src_dir)
# Download boto file (needed by recreate_skps.py) to tmp dir.

Powered by Google App Engine
This is Rietveld 408576698