infra/bots/recipe_modules/skia/api.py - Issue 2199273002: Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipe_modules/skia/api.py

Issue 2199273002: Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix platforms for GN Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: infra/bots/recipe_modules/skia/api.py

diff --git a/infra/bots/recipe_modules/skia/api.py b/infra/bots/recipe_modules/skia/api.py

index a173601e64badea13f16854323bcc4bed2253bec..96467eaaff19b47ad921981ca6a39edb21f86c81 100644

--- a/infra/bots/recipe_modules/skia/api.py

+++ b/infra/bots/recipe_modules/skia/api.py

@@ -194,6 +194,9 @@ class SkiaApi(recipe_api.RecipeApi):

'SAN' in self.builder_name) or

'RecreateSKPs' in self.builder_name):

self._need_chromium_checkout = True

+ if 'RecreateSKPs' in self.builder_name:

+ self.gclient_env['CPPFLAGS'] = (

+ '-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1')

# Some bots also require a checkout of PDFium.

self._need_pdfium_checkout = 'PDFium' in self.builder_name

« no previous file with comments | « no previous file | infra/bots/recipes/swarm_RecreateSKPs.py » ('j') | tools/build_command_buffer.py » ('J')