infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json - Issue 2199273002: Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json

Issue 2199273002: Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix platforms for GN Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json ('k') | tools/build_command_buffer.py » ('j') | tools/build_command_buffer.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json

diff --git a/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json b/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json

index 51875510ee2931a1fcd3f4a6202539642d7af9b2..756babc7fb127d0cbab154d93f75a888597d32e1 100644

--- a/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json

+++ b/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json

@@ -84,6 +84,7 @@

"cwd": "[CUSTOM_/_B_WORK]",

"env": {

+ "CPPFLAGS": "-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1",

"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"

"name": "gclient runhooks"

@@ -151,34 +152,22 @@

{

"cmd": [

- "python",

- "-u",

- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",

- "runhooks"

- ],

- "cwd": "[CUSTOM_/_B_WORK]/skia",

- "env": {

- "CPPFLAGS": "-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1",

- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"

- },

- "name": "gclient runhooks (2)"

- },

- {

- "cmd": [

- "build/gyp_chromium"

+ "[CUSTOM_/_B_WORK]/src/buildtools/linux64/gn",

+ "gen",

+ "[CUSTOM_/_B_WORK]/src/out/Release"

"cwd": "[CUSTOM_/_B_WORK]/src",

"env": {

"CPPFLAGS": "-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1",

"GYP_GENERATORS": "ninja"

- "name": "gyp_chromium"

+ "name": "GN"

{

"cmd": [

"ninja",

"-C",

- "out/Release",

+ "[CUSTOM_/_B_WORK]/src/out/Release",

"chrome"

"cwd": "[CUSTOM_/_B_WORK]/src",