Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2199213003: Use NotAllowedError instead of PermissionDeniedError for the Push API (Closed)

Created:
4 years, 4 months ago by Peter Beverloo
Modified:
4 years, 4 months ago
Reviewers:
harkness, whywhat
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, haraken, harkness+watch_chromium.org, jam, johnme+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use NotAllowedError instead of PermissionDeniedError for the Push API BUG=611340 Committed: https://crrev.com/bd3b430d88ca5ffb6544c0283cdf6a65489eede2 Cr-Commit-Position: refs/heads/master@{#409766}

Patch Set 1 #

Patch Set 2 : alphabetize #

Patch Set 3 : fix the browser tests #

Messages

Total messages: 18 (11 generated)
Peter Beverloo
+harkness for review
4 years, 4 months ago (2016-08-02 17:03:53 UTC) #2
harkness
On 2016/08/02 17:03:53, Peter Beverloo wrote: > +harkness for review LGTM
4 years, 4 months ago (2016-08-03 11:09:50 UTC) #5
whywhat
lgtm You may want to fix chrome/browser/push_messaging/push_messaging_browsertest.cc too.
4 years, 4 months ago (2016-08-03 12:47:21 UTC) #7
Peter Beverloo
On 2016/08/03 12:47:21, whywhat wrote: > lgtm > You may want to fix chrome/browser/push_messaging/push_messaging_browsertest.cc > ...
4 years, 4 months ago (2016-08-04 11:09:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199213003/40001
4 years, 4 months ago (2016-08-04 12:20:50 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-04 12:24:18 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 12:26:18 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd3b430d88ca5ffb6544c0283cdf6a65489eede2
Cr-Commit-Position: refs/heads/master@{#409766}

Powered by Google App Engine
This is Rietveld 408576698