content/renderer/push_messaging/push_messaging_dispatcher.cc - Issue 2199213003: Use NotAllowedError instead of PermissionDeniedError for the Push API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.cc

Issue 2199213003: Use NotAllowedError instead of PermissionDeniedError for the Push API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the browser tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | third_party/WebKit/LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/push_messaging/push_messaging_dispatcher.cc

diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.cc b/content/renderer/push_messaging/push_messaging_dispatcher.cc

index 75e6e1032db9f778ff7ec922dd1dc85b90415a3b..7c89a765306072cc031cc8a3a5a9039b769aab15 100644

--- a/content/renderer/push_messaging/push_messaging_dispatcher.cc

+++ b/content/renderer/push_messaging/push_messaging_dispatcher.cc

@@ -138,7 +138,7 @@ void PushMessagingDispatcher::OnSubscribeFromDocumentError(

blink::WebPushError::ErrorType error_type =

status == PUSH_REGISTRATION_STATUS_PERMISSION_DENIED

- ? blink::WebPushError::ErrorTypePermissionDenied

+ ? blink::WebPushError::ErrorTypeNotAllowed

: blink::WebPushError::ErrorTypeAbort;

callbacks->onError(blink::WebPushError(