third_party/WebKit/Source/modules/push_messaging/PushError.cpp - Issue 2199213003: Use NotAllowedError instead of PermissionDeniedError for the Push API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushError.cpp

Issue 2199213003: Use NotAllowedError instead of PermissionDeniedError for the Push API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the browser tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html ('k') | third_party/WebKit/public/platform/modules/push_messaging/WebPushError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushError.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushError.cpp b/third_party/WebKit/Source/modules/push_messaging/PushError.cpp

index 6b8d611399514f355fc82273c29d7c895f37e90e..9effbe4c98ecacd768f57cf90fb4666e1558814e 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushError.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushError.cpp

@@ -17,12 +17,12 @@ DOMException* PushError::take(ScriptPromiseResolver*, const WebPushError& webErr

return DOMException::create(AbortError, webError.message);

case WebPushError::ErrorTypeNetwork:

return DOMException::create(NetworkError, webError.message);

+ case WebPushError::ErrorTypeNotAllowed:

+ return DOMException::create(NotAllowedError, webError.message);

case WebPushError::ErrorTypeNotFound:

return DOMException::create(NotFoundError, webError.message);

case WebPushError::ErrorTypeNotSupported:

return DOMException::create(NotSupportedError, webError.message);

- case WebPushError::ErrorTypePermissionDenied:

- return DOMException::create(PermissionDeniedError, webError.message);

case WebPushError::ErrorTypeUnknown:

return DOMException::create(UnknownError, webError.message);

}