Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Side by Side Diff: third_party/WebKit/Source/modules/push_messaging/PushError.cpp

Issue 2199213003: Use NotAllowedError instead of PermissionDeniedError for the Push API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the browser tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/push_messaging/PushError.h" 5 #include "modules/push_messaging/PushError.h"
6 6
7 #include "core/dom/DOMException.h" 7 #include "core/dom/DOMException.h"
8 #include "core/dom/ExceptionCode.h" 8 #include "core/dom/ExceptionCode.h"
9 #include "wtf/Assertions.h" 9 #include "wtf/Assertions.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 DOMException* PushError::take(ScriptPromiseResolver*, const WebPushError& webErr or) 13 DOMException* PushError::take(ScriptPromiseResolver*, const WebPushError& webErr or)
14 { 14 {
15 switch (webError.errorType) { 15 switch (webError.errorType) {
16 case WebPushError::ErrorTypeAbort: 16 case WebPushError::ErrorTypeAbort:
17 return DOMException::create(AbortError, webError.message); 17 return DOMException::create(AbortError, webError.message);
18 case WebPushError::ErrorTypeNetwork: 18 case WebPushError::ErrorTypeNetwork:
19 return DOMException::create(NetworkError, webError.message); 19 return DOMException::create(NetworkError, webError.message);
20 case WebPushError::ErrorTypeNotAllowed:
21 return DOMException::create(NotAllowedError, webError.message);
20 case WebPushError::ErrorTypeNotFound: 22 case WebPushError::ErrorTypeNotFound:
21 return DOMException::create(NotFoundError, webError.message); 23 return DOMException::create(NotFoundError, webError.message);
22 case WebPushError::ErrorTypeNotSupported: 24 case WebPushError::ErrorTypeNotSupported:
23 return DOMException::create(NotSupportedError, webError.message); 25 return DOMException::create(NotSupportedError, webError.message);
24 case WebPushError::ErrorTypePermissionDenied:
25 return DOMException::create(PermissionDeniedError, webError.message);
26 case WebPushError::ErrorTypeUnknown: 26 case WebPushError::ErrorTypeUnknown:
27 return DOMException::create(UnknownError, webError.message); 27 return DOMException::create(UnknownError, webError.message);
28 } 28 }
29 NOTREACHED(); 29 NOTREACHED();
30 return DOMException::create(UnknownError); 30 return DOMException::create(UnknownError);
31 } 31 }
32 32
33 } // namespace blink 33 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698