Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2198443004: [DevTools] Fix location.script().sourceURL (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix location.script().sourceURL Script can be null. BUG=607532 R=lushnikov@chromium.org Committed: https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1 Cr-Commit-Position: refs/heads/master@{#408843}

Patch Set 1 #

Total comments: 2

Patch Set 2 : a #

Total comments: 2

Messages

Total messages: 11 (3 generated)
kozy
Andrey, please take a look!
4 years, 4 months ago (2016-07-29 23:34:21 UTC) #1
lushnikov
lgtm https://codereview.chromium.org/2198443004/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js File third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js (right): https://codereview.chromium.org/2198443004/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js#newcode450 third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:450: var script = location.script(); while we're here, let's ...
4 years, 4 months ago (2016-07-29 23:37:43 UTC) #2
kozy
https://codereview.chromium.org/2198443004/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js File third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js (right): https://codereview.chromium.org/2198443004/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js#newcode450 third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:450: var script = location.script(); On 2016/07/29 23:37:43, lushnikov wrote: ...
4 years, 4 months ago (2016-07-29 23:54:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198443004/20001
4 years, 4 months ago (2016-07-29 23:54:37 UTC) #6
lushnikov
https://codereview.chromium.org/2198443004/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js File third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js (right): https://codereview.chromium.org/2198443004/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js#newcode160 third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:160: this._ensureInfoForScript(/** @type {!WebInspector.Script} */(location.script())); why are you sure there's ...
4 years, 4 months ago (2016-07-30 01:03:06 UTC) #7
kozy
https://codereview.chromium.org/2198443004/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js File third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js (right): https://codereview.chromium.org/2198443004/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js#newcode160 third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:160: this._ensureInfoForScript(/** @type {!WebInspector.Script} */(location.script())); On 2016/07/30 01:03:06, lushnikov wrote: ...
4 years, 4 months ago (2016-07-30 01:19:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-30 02:18:32 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 02:20:24 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1
Cr-Commit-Position: refs/heads/master@{#408843}

Powered by Google App Engine
This is Rietveld 408576698