third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js - Issue 2198443004: [DevTools] Fix location.script().sourceURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

Issue 2198443004: [DevTools] Fix location.script().sourceURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js ('k') | third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

index ab89ed06a24b96a872b24e24048ce17a296cab89..78f6ebd7e0c9f633cbd13171b33ed82c6728f53d 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

@@ -157,7 +157,7 @@ WebInspector.DebuggerWorkspaceBinding.prototype = {

createCallFrameLiveLocation: function(location, updateDelegate, locationPool)

{

var target = location.target();

- this._ensureInfoForScript(location.script());

+ this._ensureInfoForScript(/** @type {!WebInspector.Script} */(location.script()));

lushnikov 2016/07/30 01:03:06 why are you sure there's a script?

kozy 2016/07/30 01:19:03 I'll address it in followup: crbug.com/632933

var liveLocation = this.createLiveLocation(location, updateDelegate, locationPool);

this._registerCallFrameLiveLocation(target, liveLocation);

return liveLocation;